From: Dmitriy Paliy <dmitriy.paliy@nokia.com>
To: ext Bastien Nocera <hadess@hadess.net>
Cc: linux-bluetooth@vger.kernel.org, szymon.janc@tieto.com
Subject: Re: [PATCH] Fix adapter drivers unload order
Date: Fri, 18 Mar 2011 13:59:01 +0200 [thread overview]
Message-ID: <1300449541.2484.5.camel@dp-x301> (raw)
In-Reply-To: <1300448640.2478.0.camel@novo.hadess.net>
Hi,
> > - adapter->loaded_drivers = g_slist_prepend(adapter->loaded_drivers,
> > - driver);
> > + adapter->loaded_drivers = g_slist_append(adapter->loaded_drivers,
> > + driver);
>
> That's usually g_slist_prepend() followed by a g_slist_reverse(), not a
> g_slist_append().
In this case append looks more appropriate if we want to be consistent
with rest of code. To be more specific with audio_manager_init and
audio_manager_exit, and btd_register_adapter_driver where drivers are
appended
adapter_drivers = g_slist_append(adapter_drivers, driver);
BR,
Dmitriy
next prev parent reply other threads:[~2011-03-18 11:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-18 8:25 [PATCH] Fix adapter drivers unload order Dmitriy Paliy
2011-03-18 11:43 ` Bastien Nocera
2011-03-18 11:59 ` Dmitriy Paliy [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-03-18 14:18 [PATCH 0/1 v2] " Dmitriy Paliy
2011-03-18 14:18 ` [PATCH] " Dmitriy Paliy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300449541.2484.5.camel@dp-x301 \
--to=dmitriy.paliy@nokia.com \
--cc=hadess@hadess.net \
--cc=linux-bluetooth@vger.kernel.org \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox