From: luiz.dentz@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 3/3 v2] Fix uninitialized variables warnings
Date: Tue, 29 Mar 2011 16:47:44 +0300 [thread overview]
Message-ID: <1301406464-3404-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1301406464-3404-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.dentz-von@nokia.com>
src/attrib-server.c: In function ‘channel_handler’:
src/attrib-server.c:297:21: error: ‘cur’ may be used uninitialized in this function
src/attrib-server.c:502:10: error: ‘format’ may be used uninitialized in this function
src/attrib-server.c:503:11: error: ‘length’ may be used uninitialized in this function
make[1]: *** [src/attrib-server.o] Error 1
---
src/attrib-server.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/src/attrib-server.c b/src/attrib-server.c
index dc05d7e..98bd6b1 100644
--- a/src/attrib-server.c
+++ b/src/attrib-server.c
@@ -315,7 +315,7 @@ static uint16_t read_by_group(struct gatt_channel *channel, uint16_t start,
ATT_ECODE_UNSUPP_GRP_TYPE, pdu, len);
last_handle = end;
- for (l = database, groups = NULL; l; l = l->next) {
+ for (l = database, groups = NULL, cur = NULL; l; l = l->next) {
struct attribute *client_attr;
a = l->data;
@@ -538,6 +538,9 @@ static int find_info(uint16_t start, uint16_t end, uint8_t *pdu, int len)
} else if (last_type == BT_UUID128) {
length = 16;
format = 0x02;
+ } else {
+ g_slist_free(info);
+ return 0;
}
adl = att_data_list_alloc(num, length + 2);
--
1.7.4.1
next prev parent reply other threads:[~2011-03-29 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 13:47 [PATCH 2/3 v2] Fix uninitialized variable warning luiz.dentz
2011-03-29 13:47 ` luiz.dentz [this message]
2011-03-29 15:08 ` [PATCH 3/3 v2] Fix uninitialized variables warnings Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301406464-3404-2-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox