Re: [PATCH] Bluetooth: Fix unconditional call to mgmt interface in hci_event.c

[Marcel Holtmann <marcel@holtmann.org>]

Hi Szymon,

> hci_cc_read_local_oob_data_reply funtion should call
> mgmt_read_local_oob_data_reply_complete only if management interface
> is enabled.
> 
> Signed-off-by: Szymon Janc <szymon.janc@tieto.com>
> ---
>  net/bluetooth/hci_event.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 7a3398d..9062e1b 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -831,7 +831,8 @@ static void hci_cc_read_local_oob_data_reply(struct hci_dev *hdev,
>  
>  	BT_DBG("%s status 0x%x", hdev->name, rp->status);
>  

please just exit the function if flag is not set:

	if (!test_bit(...))
		return

> -	mgmt_read_local_oob_data_reply_complete(hdev->id, rp->hash,
> +	if (test_bit(HCI_MGMT, &hdev->flags))
> +		mgmt_read_local_oob_data_reply_complete(hdev->id, rp->hash,
>  						rp->randomizer, rp->status);
>  }
>  

Regards

Marcel