From: David Herrmann <dh.herrmann@googlemail.com>
To: linux-bluetooth@vger.kernel.org
Cc: johan.hedberg@gmail.com, David Herrmann <dh.herrmann@googlemail.com>
Subject: [PATCH] Remove unnecessary code from pin handler
Date: Sun, 10 Apr 2011 17:48:11 +0200 [thread overview]
Message-ID: <1302450491-26550-1-git-send-email-dh.herrmann@googlemail.com> (raw)
The source address is not used inside the pin handler and, thus,
can be skipped.
---
src/event.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/src/event.c b/src/event.c
index 4ca1be5..5373e33 100644
--- a/src/event.c
+++ b/src/event.c
@@ -105,7 +105,7 @@ static void pincode_cb(struct agent *agent, DBusError *derr,
const char *pincode, struct btd_device *device)
{
struct btd_adapter *adapter = device_get_adapter(device);
- bdaddr_t sba, dba;
+ bdaddr_t dba;
int err;
device_get_address(device, &dba);
@@ -121,8 +121,6 @@ static void pincode_cb(struct agent *agent, DBusError *derr,
if (err < 0)
goto fail;
- adapter_get_address(adapter, &sba);
-
return;
fail:
--
1.7.4.4
next reply other threads:[~2011-04-10 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-10 15:48 David Herrmann [this message]
2011-04-14 17:04 ` [PATCH] Remove unnecessary code from pin handler Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302450491-26550-1-git-send-email-dh.herrmann@googlemail.com \
--to=dh.herrmann@googlemail.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox