From: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
To: Johan Hedberg <johan.hedberg@gmail.com>, <padovan@profusion.mobi>
Cc: <linux-bluetooth@vger.kernel.org>,
Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
Subject: [PATCH v3 4/7] Bluetooth: Ignore key unauthenticated for high security
Date: Thu, 28 Apr 2011 12:07:56 +0200 [thread overview]
Message-ID: <1303985279-3944-5-git-send-email-waldemar.rymarkiewicz@tieto.com> (raw)
In-Reply-To: <1303985279-3944-1-git-send-email-waldemar.rymarkiewicz@tieto.com>
High security level for pre v2.1 devices requires combination link key
authenticated by at least 16 digit PIN code.
It's also necessary to update key_type and pin_length when the key
exists and is sufficently secured for the connection as there will be
no link key notify event in that case.
Signed-off-by: Waldemar Rymarkiewicz <waldemar.rymarkiewicz@tieto.com>
---
net/bluetooth/hci_event.c | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 655af8b..40e96cd 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -2059,11 +2059,23 @@ static inline void hci_link_key_request_evt(struct hci_dev *hdev, struct sk_buff
}
conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, &ev->bdaddr);
+ if (conn) {
+ if (key->type == HCI_LK_UNAUTH_COMBINATION &&
+ conn->auth_type != 0xff &&
+ (conn->auth_type & 0x01)) {
+ BT_DBG("%s ignoring unauthenticated key", hdev->name);
+ goto not_found;
+ }
- if (key->type == HCI_LK_UNAUTH_COMBINATION && conn &&
- conn->auth_type != 0xff && (conn->auth_type & 0x01)) {
- BT_DBG("%s ignoring unauthenticated key", hdev->name);
- goto not_found;
+ if (key->type == HCI_LK_COMBINATION && key->pin_len < 16 &&
+ conn->pending_sec_level == BT_SECURITY_HIGH) {
+ BT_DBG("%s ignoring key unauthenticated for high \
+ security", hdev->name);
+ goto not_found;
+ }
+
+ conn->key_type = key->type;
+ conn->pin_length = key->pin_len;
}
bacpy(&cp.bdaddr, &ev->bdaddr);
--
1.7.1
next prev parent reply other threads:[~2011-04-28 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-28 10:07 [PATCH v3 0/7] Handle link key type and security requirements Waldemar Rymarkiewicz
2011-04-28 10:07 ` [PATCH v3 1/7] Bluetooth: Add definitions for link key types Waldemar Rymarkiewicz
2011-04-28 10:07 ` [PATCH v3 2/7] Bluetooth: Don't modify sec_level if auth failed Waldemar Rymarkiewicz
2011-04-28 10:07 ` [PATCH v3 3/7] Bluetooth: Map sec_level to link key requirements Waldemar Rymarkiewicz
2011-04-28 10:07 ` Waldemar Rymarkiewicz [this message]
2011-04-28 10:07 ` [PATCH v3 5/7] Bluetooth: Double check sec req for pre 2.1 device Waldemar Rymarkiewicz
2011-04-28 18:09 ` Gustavo F. Padovan
2011-04-29 8:23 ` Waldemar.Rymarkiewicz
2011-04-28 18:11 ` Johan Hedberg
2011-04-28 21:08 ` Johan Hedberg
2011-04-29 8:30 ` Waldemar.Rymarkiewicz
2011-04-29 8:10 ` Waldemar.Rymarkiewicz
2011-04-28 10:07 ` [PATCH v3 6/7] Bluetooth: Respect local MITM req in io_cap reply Waldemar Rymarkiewicz
2011-04-28 10:07 ` [PATCH v3 7/7] Bluetooth: Add secure flag for mgmt_pin_code_req Waldemar Rymarkiewicz
2011-04-28 18:34 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303985279-3944-5-git-send-email-waldemar.rymarkiewicz@tieto.com \
--to=waldemar.rymarkiewicz@tieto.com \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox