linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: johan.hedberg@gmail.com
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 08/12] Bluetooth: Fix old_key_type logic for non-persistent keys
Date: Thu, 28 Apr 2011 11:29:00 -0700	[thread overview]
Message-ID: <1304015344-12238-8-git-send-email-johan.hedberg@gmail.com> (raw)
In-Reply-To: <1304015344-12238-1-git-send-email-johan.hedberg@gmail.com>

From: Johan Hedberg <johan.hedberg@nokia.com>

Even if there's no previous key stored the connection might still be
secured with a non-persistent key and in that case the key type in the
hci_conn struct should be checked.

Signed-off-by: Johan Hedberg <johan.hedberg@nokia.com>
---
 net/bluetooth/hci_core.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 85fae57..88ed4ff 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1069,7 +1069,7 @@ int hci_add_link_key(struct hci_dev *hdev, struct hci_conn *conn, int new_key,
 		old_key_type = old_key->type;
 		key = old_key;
 	} else {
-		old_key_type = 0xff;
+		old_key_type = conn ? conn->key_type : 0xff;
 		key = kzalloc(sizeof(*key), GFP_ATOMIC);
 		if (!key)
 			return -ENOMEM;
-- 
1.7.4.4


  parent reply	other threads:[~2011-04-28 18:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 18:28 [PATCH 01/12] Bluetooth: Add automated SSP user confirmation responses johan.hedberg
2011-04-28 18:28 ` [PATCH 02/12] Bluetooth: Add variable SSP auto-accept delay support johan.hedberg
2011-04-28 18:28 ` [PATCH 03/12] Bluetooth: Fix HCI_CONN_AUTH_PEND flag for all authentication requests johan.hedberg
2011-04-28 18:28 ` [PATCH 04/12] Bluetooth: Add confirm_hint parameter to user confirmation requests johan.hedberg
2011-04-28 18:28 ` [PATCH 05/12] Bluetooth: Fix reason code for pairing rejection johan.hedberg
2011-04-28 18:28 ` [PATCH 06/12] Bluetooth: Fix logic in hci_pin_code_request_evt johan.hedberg
2011-04-28 18:28 ` [PATCH 07/12] Bluetooth: Fix link key persistent storage criteria johan.hedberg
2011-04-28 18:29 ` johan.hedberg [this message]
2011-04-28 18:29 ` [PATCH 09/12] Bluetooth: Fix connection key type updating for buggy controllers johan.hedberg
2011-04-28 18:29 ` [PATCH 10/12] Bluetooth: Remove old_key_type from mgmt_ev_new_key johan.hedberg
2011-04-28 18:29 ` [PATCH 11/12] Bluetooth: Add store_hint parameter to mgmt_new_key johan.hedberg
2011-04-28 18:29 ` [PATCH 12/12] Bluetooth: Fix updating conn->auth_type in hci_io_capa_request_evt johan.hedberg
2011-04-28 19:18   ` Gustavo F. Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304015344-12238-8-git-send-email-johan.hedberg@gmail.com \
    --to=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).