* [PATCH] Fix property type of Main Channel of Health plugin
@ 2011-04-29 21:01 Jaikumar Ganesh
2011-05-02 17:24 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Jaikumar Ganesh @ 2011-04-29 21:01 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Jaikumar Ganesh
The property type must be DBUS_TYPE_OBJECT_PATH instead
of DBUS_TYPE_STRING. This is in sync with the documentation
and with the other places of usage such as the property change
signal.
---
health/hdp.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/health/hdp.c b/health/hdp.c
index 6f2c89d..d53ea80 100644
--- a/health/hdp.c
+++ b/health/hdp.c
@@ -2058,7 +2058,7 @@ static DBusMessage *device_get_properties(DBusConnection *conn,
path = g_strdup(device->fr->path);
else
path = g_strdup("");
- dict_append_entry(&dict, "MainChannel", DBUS_TYPE_STRING, &path);
+ dict_append_entry(&dict, "MainChannel", DBUS_TYPE_OBJECT_PATH, &path);
g_free(path);
dbus_message_iter_close_container(&iter, &dict);
--
1.7.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix property type of Main Channel of Health plugin
2011-04-29 21:01 [PATCH] Fix property type of Main Channel of Health plugin Jaikumar Ganesh
@ 2011-05-02 17:24 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-05-02 17:24 UTC (permalink / raw)
To: Jaikumar Ganesh; +Cc: linux-bluetooth
Hi Jaikumar,
On Fri, Apr 29, 2011, Jaikumar Ganesh wrote:
> The property type must be DBUS_TYPE_OBJECT_PATH instead
> of DBUS_TYPE_STRING. This is in sync with the documentation
> and with the other places of usage such as the property change
> signal.
> ---
> health/hdp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Pushed upstream. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-02 17:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-29 21:01 [PATCH] Fix property type of Main Channel of Health plugin Jaikumar Ganesh
2011-05-02 17:24 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).