Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Waldemar.Rymarkiewicz@tieto.com
Cc: linux-bluetooth@vger.kernel.org, johan.hedberg@gmail.com
Subject: RE: [PATCH 1/2] Add secure param to Mgmt PIN Code Request Event
Date: Mon, 02 May 2011 08:31:00 -0700	[thread overview]
Message-ID: <1304350260.15916.102.camel@aeonflux> (raw)
In-Reply-To: <99B09243E1A5DA4898CDD8B70011144816F29AF32A@EXMB04.eu.tieto.com>

Hi Waldemar,

> >> @@ -482,6 +482,7 @@ PIN Code Request Event
> >>  Event Code		0x000E
> >>  Controller Index:	<controller id>
> >>  Event Parameters	Address (6 Octets)
> >> +			Secure (1 Octet)
> >
> >we do need to document possible values and their meanings. Is 
> >this a boolean or is this suppose to indicate the PIN code length?
> 
> It's boolean. 	
> Do you mean something like this?
> 
> Event Code		0x000E
> Controller Index:	<controller id>
> Event Parameters	Address (6 Octets)
> 			Secure (1 Octet)
> 
> 		Secure: 0x01  16 digit PIN code required
> 			0x00  16 digit PIN code not required

yes, we need these things documented.

Obviously now the question is why not expose this as min_pin_length
value?

Regards

Marcel



  reply	other threads:[~2011-05-02 15:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 10:50 [PATCH 1/2] Add secure param to Mgmt PIN Code Request Event Waldemar Rymarkiewicz
2011-04-28 10:50 ` [PATCH 2/2] Add support of secure pin code in mgmt code Waldemar Rymarkiewicz
2011-04-28 21:04 ` [PATCH 1/2] Add secure param to Mgmt PIN Code Request Event Johan Hedberg
2011-04-30 18:46 ` Marcel Holtmann
2011-05-02  7:26   ` Waldemar.Rymarkiewicz
2011-05-02 15:31     ` Marcel Holtmann [this message]
2011-05-04  7:52       ` Waldemar.Rymarkiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1304350260.15916.102.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=Waldemar.Rymarkiewicz@tieto.com \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox