Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 00/12] Caching LE advertising information
Date: Wed, 11 May 2011 18:23:34 -0700	[thread overview]
Message-ID: <1305163414.15916.165.camel@aeonflux> (raw)
In-Reply-To: <1304701521-26459-1-git-send-email-andre.guedes@openbossa.org>

Hi Andre,

> This patchset implements the LE advertising cache which is used
> to establish LE connections.
> 
> Today, we cannot establish LE connections (via l2cap socket) with
> devices which use random address type. To achieve that, we came up
> with a solution where the host should be able to infer the address
> type (public or random) from the device it wants to connect to.
> 
> The approach this patchset implements is: during the LE scanning,
> the host stores the address and the address type gathered from
> advertising reports. These information are stored at the advertising
> cache. So, during a LE connection, the host looks up the advertising
> cache and gets the address type from the device it wants to connect
> to.

I would prefer if we try using the cache as long as possible. As long as
this works out it should be fine. Adding the BDADDR_TYPE to all public
socket address structures seems a bit of a pain to me.

And as backup we can always revert to that, but we can never ever remove
that address from the socket structure. While we can remove the cache if
we no longer need it.

Regards

Marcel



      parent reply	other threads:[~2011-05-12  1:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-06 17:05 [PATCH 00/12] Caching LE advertising information Andre Guedes
2011-05-06 17:05 ` [PATCH 01/12] Bluetooth: Add advertising report meta event structs Andre Guedes
2011-05-06 17:05 ` [PATCH 02/12] Bluetooth: LE advertising cache Andre Guedes
2011-05-13 19:33   ` Gustavo F. Padovan
2011-05-17 18:22     ` Andre Guedes
2011-05-17 18:43       ` Gustavo F. Padovan
2011-05-06 17:05 ` [PATCH 03/12] Bluetooth: Protect 'adv_entries' with a RW lock Andre Guedes
2011-05-12  1:24   ` Marcel Holtmann
2011-05-17 14:39     ` Andre Guedes
2011-05-06 17:05 ` [PATCH 04/12] Bluetooth: Add advertising report meta event handler Andre Guedes
2011-05-06 17:05 ` [PATCH 05/12] Bluetooth: LE Set Scan Enable command complete event Andre Guedes
2011-05-06 17:05 ` [PATCH 06/12] Bluetooth: Clear advertising cache before scanning Andre Guedes
2011-05-06 17:05 ` [PATCH 07/12] Bluetooth: Advertising entries lifetime Andre Guedes
2011-05-06 17:05 ` [PATCH 08/12] Bluetooth: Add 'dst_type' field to struct hci_conn Andre Guedes
2011-05-06 17:05 ` [PATCH 09/12] Bluetooth: Add hci_le_conn_add() Andre Guedes
2011-05-12  1:27   ` Marcel Holtmann
2011-05-06 17:05 ` [PATCH 10/12] Bluetooth: Remove useless check in hci_connect() Andre Guedes
2011-05-06 17:05 ` [PATCH 11/12] Bluetooth: Check advertising cache " Andre Guedes
2011-05-06 17:05 ` [PATCH 12/12] Bluetooth: Set 'peer_addr_type' in hci_le_connect() Andre Guedes
2011-05-12  1:23 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1305163414.15916.165.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox