From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 03/12] Bluetooth: Protect 'adv_entries' with a RW lock
Date: Wed, 11 May 2011 18:24:34 -0700 [thread overview]
Message-ID: <1305163474.15916.166.camel@aeonflux> (raw)
In-Reply-To: <1304701521-26459-4-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
> This patch adds a RW lock to protect concurrent operations on
> adv_entries list.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c | 21 +++++++++++++++++----
> 2 files changed, 18 insertions(+), 4 deletions(-)
>
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index 65135f8..2ceeadf 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -188,6 +188,7 @@ struct hci_dev {
> struct list_head remote_oob_data;
>
> struct list_head adv_entries;
> + rwlock_t adv_entries_lock;
we might wanna consider just using spinlocks and not rwlocks. Also can
you please look into using RCU.
Regards
Marcel
next prev parent reply other threads:[~2011-05-12 1:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-06 17:05 [PATCH 00/12] Caching LE advertising information Andre Guedes
2011-05-06 17:05 ` [PATCH 01/12] Bluetooth: Add advertising report meta event structs Andre Guedes
2011-05-06 17:05 ` [PATCH 02/12] Bluetooth: LE advertising cache Andre Guedes
2011-05-13 19:33 ` Gustavo F. Padovan
2011-05-17 18:22 ` Andre Guedes
2011-05-17 18:43 ` Gustavo F. Padovan
2011-05-06 17:05 ` [PATCH 03/12] Bluetooth: Protect 'adv_entries' with a RW lock Andre Guedes
2011-05-12 1:24 ` Marcel Holtmann [this message]
2011-05-17 14:39 ` Andre Guedes
2011-05-06 17:05 ` [PATCH 04/12] Bluetooth: Add advertising report meta event handler Andre Guedes
2011-05-06 17:05 ` [PATCH 05/12] Bluetooth: LE Set Scan Enable command complete event Andre Guedes
2011-05-06 17:05 ` [PATCH 06/12] Bluetooth: Clear advertising cache before scanning Andre Guedes
2011-05-06 17:05 ` [PATCH 07/12] Bluetooth: Advertising entries lifetime Andre Guedes
2011-05-06 17:05 ` [PATCH 08/12] Bluetooth: Add 'dst_type' field to struct hci_conn Andre Guedes
2011-05-06 17:05 ` [PATCH 09/12] Bluetooth: Add hci_le_conn_add() Andre Guedes
2011-05-12 1:27 ` Marcel Holtmann
2011-05-06 17:05 ` [PATCH 10/12] Bluetooth: Remove useless check in hci_connect() Andre Guedes
2011-05-06 17:05 ` [PATCH 11/12] Bluetooth: Check advertising cache " Andre Guedes
2011-05-06 17:05 ` [PATCH 12/12] Bluetooth: Set 'peer_addr_type' in hci_le_connect() Andre Guedes
2011-05-12 1:23 ` [PATCH 00/12] Caching LE advertising information Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305163474.15916.166.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).