From: Marcel Holtmann <marcel@holtmann.org>
To: "Gustavo F. Padovan" <padovan@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/6] Bluetooth: Add chan->link_type struct member
Date: Thu, 12 May 2011 12:07:25 -0700 [thread overview]
Message-ID: <1305227245.15916.173.camel@aeonflux> (raw)
In-Reply-To: <1305178350-7568-3-git-send-email-padovan@profusion.mobi>
Hi Gustavo,
> link_type says if our link is raw, connection less or connection oriented.
>
> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
> include/net/bluetooth/l2cap.h | 5 +++++
> net/bluetooth/l2cap_core.c | 30 +++++++++++-------------------
> net/bluetooth/l2cap_sock.c | 30 +++++++++++++++++++++++-------
> 3 files changed, 39 insertions(+), 26 deletions(-)
>
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index dc721ca..6915c43 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -295,6 +295,7 @@ struct l2cap_chan {
> __u16 omtu;
> __u16 flush_to;
> __u8 mode;
> + __u8 link_type;
>
> __le16 sport;
>
> @@ -384,6 +385,10 @@ struct l2cap_conn {
> #define L2CAP_INFO_FEAT_MASK_REQ_SENT 0x04
> #define L2CAP_INFO_FEAT_MASK_REQ_DONE 0x08
>
> +#define L2CAP_LINK_RAW 1
> +#define L2CAP_LINK_CONNLESS 2
> +#define L2CAP_LINK_ORIENTED 3
> +
the name ORIENTED is a pretty bad name. Use CONN_ORIENTED and CONN_LESS
to make this more clear. And use CONN_LESS instead of CONNLESS to have
this in sync with other constants we have.
Regards
Marcel
next prev parent reply other threads:[~2011-05-12 19:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 5:32 [PATCH 1/6] Bluetooth: Create __l2cap_chan_close() Gustavo F. Padovan
2011-05-12 5:32 ` [PATCH 2/6] Bluetooth: Create l2cap_chan_send() Gustavo F. Padovan
2011-05-12 5:32 ` [PATCH 3/6] Bluetooth: Add chan->link_type struct member Gustavo F. Padovan
2011-05-12 5:32 ` [PATCH 4/6] Bluetooth: create channel timer to replace sk_timer Gustavo F. Padovan
2011-05-12 5:32 ` [PATCH 5/6] Bluetooth: Remove export of l2cap_chan_clear_timer() Gustavo F. Padovan
2011-05-12 5:32 ` [PATCH 6/6] Bluetooth: Rename __l2cap_chan_close() to l2cap_chan_close() Gustavo F. Padovan
2011-05-12 17:37 ` [PATCH 3/6] Bluetooth: Add chan->link_type struct member Vinicius Costa Gomes
2011-05-12 17:58 ` Anderson Lizardo
2011-05-12 19:07 ` Marcel Holtmann [this message]
2011-05-12 18:16 ` [PATCH 2/6] Bluetooth: Create l2cap_chan_send() Anderson Lizardo
2011-05-12 15:55 ` [PATCH 1/6] Bluetooth: Create __l2cap_chan_close() Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305227245.15916.173.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox