Re: [PATCH 1/2] Bluetooth: FTP and OPP over L2CAP

[Marcel Holtmann <marcel@holtmann.org>]

Hi Nami,

> From: nami <nami.li@atheros.com>
> 
> 
> Signed-off-by: Nami <nami.li@atheros.com>

the number one thing here is to get your GIT setup done right and follow
our polices like no signed-off-by line for bluez and obexd submissions.

> ---
>  client/main.c       |   26 +++++++----
>  client/session.c    |  119 ++++++++++++++++++++++++++++++++++++++++++++++----
>  client/session.h    |    6 +++
>  gwobex/gw-obex.c    |    6 +-
>  gwobex/gw-obex.h    |    3 +-
>  gwobex/obex-priv.c  |    4 +-
>  gwobex/obex-priv.h  |    2 +-
>  plugins/bluetooth.c |  112 +++++++++++++++++++++++++++++++++++++++++++++---
>  plugins/ftp.c       |    8 +++-
>  plugins/opp.c       |    8 +++-
>  src/obex.c          |   10 +++-
>  src/service.h       |    7 +++
>  test/main.c         |    2 +-
>  13 files changed, 275 insertions(+), 38 deletions(-)

And without even looking at the actual patch, I can tell you right now
here that you should have split this up into logical pieces. For example
gwobex should be it separate patch in the first place. And I assume
others can also be nicely split up.

These "monster" patches are not acceptable.

Regards

Marcel