linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: anderson.briglia@openbossa.org
Cc: linux-bluetooth@vger.kernel.org,
	Bruna Moreira <bruna.moreira@openbossa.org>
Subject: Re: [RFC 7/7] Update Management API documentation
Date: Wed, 15 Jun 2011 15:10:52 -0700	[thread overview]
Message-ID: <1308175855.2196.7.camel@aeonflux> (raw)
In-Reply-To: <4df91d74.0b73650a.190f.17ad@mx.google.com>

Hi Anderson,

> Add Read RSSI and Read TX Power level commands in Management API
> documentation.
> ---
>  doc/mgmt-api.txt |   20 ++++++++++++++++++++
>  1 files changed, 20 insertions(+), 0 deletions(-)
> 
> diff --git a/doc/mgmt-api.txt b/doc/mgmt-api.txt
> index 353705e..b442cc5 100644
> --- a/doc/mgmt-api.txt
> +++ b/doc/mgmt-api.txt
> @@ -319,6 +319,26 @@ Stop Discovery Command
>  	Command Parameters:
>  	Return Parameters:
>  
> +Read RSSI Command
> +=================
> +
> +	Command Code:		0x001D
> +	Controller Index:	<controller id>
> +	Command Parameters:	Address (6 Octets)
> +	Return Parameters:	Status (1 Octet)
> +				Address (6 Octets)
> +				RSSI (1 Octet)
> +
> +Read TX Power Level Command
> +===========================
> +
> +	Command Code:		0x001E
> +	Controller Index:	<controller id>
> +	Command Parameters:	Address (6 Octets)
> +	Return Parameters:	Address (6 Octets)
> +				Status (1 Octet)
> +				Level (1 Octet)
> +

so why are these two separate commands. Just reading them in one kernel
call might be a lot better. Including everything else you need to know
about the connection. Also TX power can be local and remote TX power if
I remember this correctly.

Regards

Marcel



  reply	other threads:[~2011-06-15 22:10 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1308171784-24442-1-git-send-email-y>
2011-06-15 21:02 ` [RFC 1/7] Add current tx power read on hciops anderson.briglia
2011-06-15 21:02 ` [RFC 2/7] Add read RSSI " anderson.briglia
2011-06-15 21:03 ` [RFC 3/7] Add RSSI read callbacks anderson.briglia
2011-06-15 21:03 ` [RFC 4/7] Add transmission power callbacks anderson.briglia
2011-06-15 21:03 ` [RFC 5/7] Implement mgmt_read_rssi command anderson.briglia
2011-06-15 21:03 ` [RFC 6/7] Implement mgmt_read_tx_power command anderson.briglia
2011-06-15 21:03 ` [RFC 7/7] Update Management API documentation anderson.briglia
2011-06-15 22:10   ` Marcel Holtmann [this message]
2011-06-15 23:47     ` Anderson Lizardo
2011-06-16  2:29       ` Marcel Holtmann
2011-06-16  6:07         ` Ganir, Chen
2011-06-16  7:54           ` Luiz Augusto von Dentz
2011-06-16 12:35             ` Claudio Takahasi
2011-06-16 14:47               ` Marcel Holtmann
2011-06-16 15:12                 ` Claudio Takahasi
2011-06-16 16:08                   ` Marcel Holtmann
2011-06-16 20:45                   ` Gustavo F. Padovan
2011-06-20 15:47                     ` Anderson Briglia
2011-06-20 16:47                       ` Marcel Holtmann
2011-06-16 13:49             ` Anderson Lizardo
2011-06-16 14:08               ` Johan Hedberg
2011-06-16 14:17                 ` Anderson Lizardo
2011-06-16  7:15         ` GATT and GATT based Profiles architecture - Query Ajay Pillai
2011-06-16 14:04           ` Anderson Lizardo
2011-06-17  9:30             ` Ajay Pillai
2011-06-17 12:10               ` Anderson Lizardo
2011-06-17 12:22                 ` Santiago Carot
2011-06-17 12:39                   ` Anderson Lizardo
2011-06-17 12:53                     ` Santiago Carot
2011-06-20  8:42                 ` Ajay Pillai
2011-06-16  6:03       ` [RFC 7/7] Update Management API documentation Ganir, Chen
2011-06-16 13:44         ` Anderson Lizardo
2011-06-16 14:19           ` Ganir, Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308175855.2196.7.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=anderson.briglia@openbossa.org \
    --cc=bruna.moreira@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).