From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [RFC] Bluetooth: Add link_type information to the mgmt Connected event
Date: Thu, 16 Jun 2011 14:50:33 -0700 [thread overview]
Message-ID: <1308261035.2196.27.camel@aeonflux> (raw)
In-Reply-To: <20110616210924.GA14812@dell.ger.corp.intel.com>
Hi Johan,
> > > -int mgmt_connected(u16 index, bdaddr_t *bdaddr)
> > > +int mgmt_connected(u16 index, bdaddr_t *bdaddr, u8 link_type)
> > > {
> > > struct mgmt_ev_connected ev;
> > >
> > > bacpy(&ev.bdaddr, bdaddr);
> > > + ev.link_type = link_type;
> > >
> > > return mgmt_event(MGMT_EV_CONNECTED, index, &ev, sizeof(ev), NULL);
> > > }
> >
> > Seems good to me. Anyone else has comments on it?
>
> It seems this is using the SCO_LINK, ESCO_LINK, ACL_LINK, and LE_LINK
> defines, right? If we're going to add an address or link type I think
> it'd be good to have the random vs public information for LE addresses
> included from the start.
we need to make up our own values here since even LE_LINK is not
official Bluetooth specification value.
Regards
Marcel
next prev parent reply other threads:[~2011-06-16 21:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 22:34 [RFC] Bluetooth: Add link_type information to the mgmt Connected event Vinicius Costa Gomes
2011-06-16 20:56 ` Gustavo F. Padovan
2011-06-16 21:09 ` Johan Hedberg
2011-06-16 21:50 ` Marcel Holtmann [this message]
2011-06-16 21:57 ` Vinicius Costa Gomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308261035.2196.27.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=vinicius.gomes@openbossa.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).