From: Marcel Holtmann <marcel@holtmann.org>
To: Nami <nami.li@atheros.com>
Cc: linux-bluetooth@vger.kernel.org, haijun@qca.qualcomm.com,
openobex-users@lists.sourceforge.net
Subject: Re: [PATCH openobex 1/3] Add transport format member in fdobex_data struct. Support STREAM and SEQPACKET transport format.
Date: Mon, 20 Jun 2011 09:43:10 -0700 [thread overview]
Message-ID: <1308588193.2196.34.camel@aeonflux> (raw)
In-Reply-To: <1308548849-11615-1-git-send-email-nami.li@atheros.com>
Hi Nami,
> include/openobex/obex_const.h | 4 ++++
> lib/fdobex.h | 1 +
> 2 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/include/openobex/obex_const.h b/include/openobex/obex_const.h
> index cb7afeb..8acee91 100644
> --- a/include/openobex/obex_const.h
> +++ b/include/openobex/obex_const.h
> @@ -302,6 +302,10 @@ enum obex_rsp_mode {
> OBEX_RSP_MODE_SINGLE = 1, /**< single response mode (SRM) */
> };
>
> +enum fdobex_transport_format{
> + FDOBEX_MT_STREAM ,
> + FDOBEX_MT_SEQPACKET
> +};
can I ask again why we should be doing this. Especially for the FdOBEX
transport this is pointless. You are getting a file descriptor in the
first place. It does not have to be a socket.
And in the case this is really a socket, then you can just use SO_TYPE
to read the current type of the socket.
If it is not a socket, then it needs to treated as stream anyway.
Regards
Marcel
next prev parent reply other threads:[~2011-06-20 16:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 5:47 [PATCH openobex 1/3] Add transport format member in fdobex_data struct. Support STREAM and SEQPACKET transport format Nami
2011-06-20 5:47 ` [PATCH openobex 2/3] Add transport format parameter when setup fd obex transprot Nami
2011-06-20 5:47 ` [PATCH openobex 3/3] Modify fdobex_read to read the entire packet when data tarnsprot format is SEQPACKET, Nami
2011-06-20 6:08 ` [PATCH openobex 1/3] Add transport format member in fdobex_data struct. Support STREAM and SEQPACKET transport format Sumangala, Suraj
2011-06-20 9:00 ` [openobex-users] " Hendrik Sattler
2011-06-20 16:43 ` Marcel Holtmann [this message]
2011-06-20 18:28 ` Hendrik Sattler
2011-06-20 19:45 ` Marcel Holtmann
2011-06-20 20:43 ` Hendrik Sattler
2011-06-21 3:17 ` Li, Nami
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308588193.2196.34.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=haijun@qca.qualcomm.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=nami.li@atheros.com \
--cc=openobex-users@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).