From: Peter Hurley <peter@hurleysoftware.com>
To: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: [PATCH] Bluetooth: Fix hidp disconnect deadlock
Date: Sat, 25 Jun 2011 17:32:35 -0400 [thread overview]
Message-ID: <1309037555.2143.5.camel@THOR> (raw)
Release reader lock on r/w sem before stopping khidp thread (which needs to
claim the writer lock on sem before unlinking the session).
NB: kthread_stop waits for thread completion.
---
net/bluetooth/hidp/core.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index c405a95..16d75d7 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -1096,6 +1096,7 @@ int hidp_del_connection(struct hidp_conndel_req *req)
{
struct hidp_session *session;
int err = 0;
+ bool stop_thread = false;
BT_DBG("");
@@ -1111,12 +1112,14 @@ int hidp_del_connection(struct hidp_conndel_req *req)
skb_queue_purge(&session->ctrl_transmit);
skb_queue_purge(&session->intr_transmit);
- kthread_stop(session->task);
+ stop_thread = true;
}
} else
err = -ENOENT;
up_read(&hidp_session_sem);
+ if (stop_thread)
+ kthread_stop(session->task);
return err;
}
--
1.7.4.1
next reply other threads:[~2011-06-25 21:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-25 21:32 Peter Hurley [this message]
2011-06-26 7:16 ` [PATCH] Bluetooth: Fix hidp disconnect deadlock Ilia, Kolominsky
2011-06-29 20:24 ` Gustavo F. Padovan
2011-06-29 20:52 ` Gustavo F. Padovan
2011-06-30 14:34 ` Peter Hurley
2011-06-30 14:46 ` gene heskett
2011-06-30 14:55 ` Ilia, Kolominsky
2011-06-30 17:47 ` Gustavo F. Padovan
2011-06-30 17:40 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309037555.2143.5.camel@THOR \
--to=peter@hurleysoftware.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox