From: Bartosz Szatkowski <bulislaw@linux.com>
To: linux-bluetooth@vger.kernel.org
Cc: Bartosz Szatkowski <bulislaw@linux.com>
Subject: [PATCH obexd 3/5 v2] Add checking ebook availability before processing
Date: Tue, 5 Jul 2011 22:53:20 +0200 [thread overview]
Message-ID: <1309899202-23849-3-git-send-email-bulislaw@linux.com> (raw)
In-Reply-To: <1309899202-23849-1-git-send-email-bulislaw@linux.com>
Some ebooks may be offline due to lack of internet connection or it may
require prior authorizations.
---
plugins/phonebook-ebook.c | 28 +++++++++++++++++-----------
1 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/plugins/phonebook-ebook.c b/plugins/phonebook-ebook.c
index 9c55860..97785b5 100644
--- a/plugins/phonebook-ebook.c
+++ b/plugins/phonebook-ebook.c
@@ -561,10 +561,12 @@ int phonebook_pull_read(void *request)
ebook = ebooks;
while (ebook != NULL) {
- ret = e_book_get_contacts_async(ebook->data, data->query,
- ebookpull_cb, data);
- if (ret == TRUE)
- data->queued_calls++;
+ if (e_book_is_opened(ebook->data) == TRUE) {
+ ret = e_book_get_contacts_async(ebook->data,
+ data->query, ebookpull_cb, data);
+ if (ret == TRUE)
+ data->queued_calls++;
+ }
ebook = ebook->next;
}
@@ -591,10 +593,12 @@ void *phonebook_get_entry(const char *folder, const char *id,
ebook = ebooks;
while (ebook != NULL) {
- ret = e_book_get_contact_async(ebook->data, data->id,
+ if (e_book_is_opened(ebook->data) == TRUE) {
+ ret = e_book_get_contact_async(ebook->data, data->id,
ebook_entry_cb, data);
- if (ret == TRUE)
- data->queued_calls++;
+ if (ret == TRUE)
+ data->queued_calls++;
+ }
ebook = ebook->next;
}
@@ -632,10 +636,12 @@ void *phonebook_create_cache(const char *name, phonebook_entry_cb entry_cb,
ebook = ebooks;
while (ebook != NULL) {
- ret = e_book_get_contacts_async(ebook->data, query,
- cache_cb, data);
- if (ret == TRUE)
- data->queued_calls++;
+ if (e_book_is_opened(ebook->data) == TRUE) {
+ ret = e_book_get_contacts_async(ebook->data, query,
+ cache_cb, data);
+ if (ret == TRUE)
+ data->queued_calls++;
+ }
ebook = ebook->next;
}
--
1.7.5.3
next prev parent reply other threads:[~2011-07-05 20:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 20:53 [PATCH obexd 1/5 v2] Change EDS backend to support multiple ebooks Bartosz Szatkowski
2011-07-05 20:53 ` [PATCH obexd 2/5 v2] Add constraint on pulled path Bartosz Szatkowski
2011-07-05 20:53 ` Bartosz Szatkowski [this message]
2011-07-05 20:53 ` [PATCH obexd 4/5 v2] Add 0.vcf (me contact) when generating cache Bartosz Szatkowski
2011-07-05 20:53 ` [PATCH obexd 5/5 v2] Add proper finishing/canceling requests Bartosz Szatkowski
2011-07-11 9:34 ` [PATCH obexd 1/5 v2] Change EDS backend to support multiple ebooks Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309899202-23849-3-git-send-email-bulislaw@linux.com \
--to=bulislaw@linux.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).