Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth: Allow ACL packets over USB in HCI_RAW mode
Date: Sun, 17 Jul 2011 13:02:13 +0200	[thread overview]
Message-ID: <1310900534.21109.116.camel@aeonflux> (raw)
In-Reply-To: <1310647712.3208.3.camel@THOR>

Hi Peter,

> Removed tests which prevent transmission of ACL packets
> when the device is in HCI_RAW mode. These tests verified that
> there are ACL or LE links currently tracked by the HCI
> connection manager. However, a HCI_RAW mode device does not
> use the connection manager. In these circumstances, the connection
> counts will be zero, and thus, transmitted ACL packets dropped.
> 
> The acl_num test is actually a vestige of a previous bulk URB
> scheme that is no longer used by this driver (bulk URBs were not
> started until at least one ACL connection was created). This was
> incompatible with some endpoint implementations and was dropped -
> see commit 43c2e57f94.
> 
> The utility of these tests is marginal - currently, the hci tx
> scheduler cannot send an ACL or LE packet for an untracked connection
> (except if the device is in HCI_RAW mode).
> 
> Lastly, no other transport layer driver enforces these same tests.

for kernel patches, we do require the Signed-off-by line.

Gustavo, I am fine with this btw. So Acked-by.

Regards

Marcel



  reply	other threads:[~2011-07-17 11:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-14 12:48 [PATCH] Bluetooth: Allow ACL packets over USB in HCI_RAW mode Peter Hurley
2011-07-17 11:02 ` Marcel Holtmann [this message]
2011-07-21 15:09 ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1310900534.21109.116.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=peter@hurleysoftware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox