* [PATCH 4/4] Bluetooth: hidp: Don't release device ref if never held
@ 2011-08-05 14:52 Peter Hurley
2011-08-11 21:07 ` Gustavo Padovan
0 siblings, 1 reply; 2+ messages in thread
From: Peter Hurley @ 2011-08-05 14:52 UTC (permalink / raw)
To: linux-bluetooth
When an hidp connection is added for a boot protocol input
device, don't release a device reference that was never
acquired. The device reference is acquired when the session
is linked to the session list (which hasn't happened yet when
hidp_setup_input is called).
Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
---
net/bluetooth/hidp/core.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/net/bluetooth/hidp/core.c b/net/bluetooth/hidp/core.c
index a859f90..fb68f34 100644
--- a/net/bluetooth/hidp/core.c
+++ b/net/bluetooth/hidp/core.c
@@ -844,7 +844,6 @@ static int hidp_setup_input(struct hidp_session *session,
if (err < 0) {
input_free_device(input);
session->input = NULL;
- hci_conn_put_device(session->conn);
return err;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] Bluetooth: hidp: Don't release device ref if never held
2011-08-05 14:52 [PATCH 4/4] Bluetooth: hidp: Don't release device ref if never held Peter Hurley
@ 2011-08-11 21:07 ` Gustavo Padovan
0 siblings, 0 replies; 2+ messages in thread
From: Gustavo Padovan @ 2011-08-11 21:07 UTC (permalink / raw)
To: Peter Hurley; +Cc: linux-bluetooth
Hi Peter,
* Peter Hurley <peter@hurleysoftware.com> [2011-08-05 10:52:01 -0400]:
> When an hidp connection is added for a boot protocol input
> device, don't release a device reference that was never
> acquired. The device reference is acquired when the session
> is linked to the session list (which hasn't happened yet when
> hidp_setup_input is called).
>
> Signed-off-by: Peter Hurley <peter@hurleysoftware.com>
> ---
> net/bluetooth/hidp/core.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
All four patches applied. Thanks.
Gustavo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-11 21:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-05 14:52 [PATCH 4/4] Bluetooth: hidp: Don't release device ref if never held Peter Hurley
2011-08-11 21:07 ` Gustavo Padovan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).