From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: Andre Guedes <andre.guedes@openbossa.org>,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 11/16] Bluetooth: Add 'eir_len' param to mgmt_device_found()
Date: Wed, 10 Aug 2011 08:17:44 -0700 [thread overview]
Message-ID: <1312989466.3373.126.camel@aeonflux> (raw)
In-Reply-To: <CAJdJm_PWZzbLvLyrr7NyXgemd_GcWH4A9=F5w93cN9qHHb_dig@mail.gmail.com>
Hi Anderson,
> >> This patch adds a new parameter to mgmt_device_found() to inform
> >> the length of 'eir' pointer.
> >>
> >> EIR data from LE advertising report event doesn't have a fixed length
> >> as EIR data from extended inquiry result event does. We needed to
> >> change mgmt_device_found() so it copies 'eir_len' bytes instead of
> >> HCI_MAX_EIR_LENGTH.
> >
> > what is the max EIR length for LE? Is it more than with BR/EDR. Or is it
> > just variable length?
>
> From page 1735:
>
> "The data consists of a significant part and a non-significant part.
> [...] The non-significant part extends the Advertising and Scan
> Response data to 31 octets and shall contain all-zero octets."
>
> So actually it is not variable length, it has 31 octets, with the
> non-significant part zero padded. BR/EDR EIR, on the other hand is 240
> bytes (with zero padding for non-significant part as well)
do we have a deep impact (memory wise) if we always pad this up to 240.
If we do, then we might wanna be smarter here anyway.
Regards
Marcel
next prev parent reply other threads:[~2011-08-10 15:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 19:49 [PATCH v2 00/16] Full support discovery procedure Andre Guedes
2011-07-25 19:49 ` [PATCH v2 01/16] Bluetooth: Periodic Inquiry and mgmt discovering event Andre Guedes
2011-07-25 19:49 ` [PATCH v2 02/16] Bluetooth: Add failed/complete functions to discovery commands Andre Guedes
2011-07-25 19:49 ` [PATCH v2 03/16] Bluetooth: Remove pending " Andre Guedes
2011-07-25 19:49 ` [PATCH v2 04/16] Bluetooth: Check pending command in start_discovery() Andre Guedes
2011-07-25 19:49 ` [PATCH v2 05/16] Bluetooth: Check pending commands in stop_discovery() Andre Guedes
2011-07-25 19:49 ` [PATCH v2 06/16] Bluetooth: Create do_inquiry() Andre Guedes
2011-07-25 19:49 ` [PATCH v2 07/16] Bluetooth: Create cancel_inquiry() Andre Guedes
2011-07-25 19:49 ` [PATCH v2 08/16] Bluetooth: Fix stop_discovery() Andre Guedes
2011-07-25 19:49 ` [PATCH v2 09/16] Bluetooth: Prepare for full support discovery procedures Andre Guedes
2011-08-10 13:48 ` Marcel Holtmann
2011-08-10 19:51 ` Andre Guedes
2011-08-11 0:24 ` Marcel Holtmann
2011-09-09 20:43 ` Andre Guedes
2011-07-25 19:49 ` [PATCH v2 10/16] Bluetooth: Check 'dev_class' in mgmt_device_found() Andre Guedes
2011-07-25 19:50 ` [PATCH v2 11/16] Bluetooth: Add 'eir_len' param to mgmt_device_found() Andre Guedes
2011-08-10 13:50 ` Marcel Holtmann
2011-08-10 14:42 ` Anderson Lizardo
2011-08-10 15:17 ` Marcel Holtmann [this message]
2011-08-10 19:51 ` Andre Guedes
2011-08-10 20:58 ` Anderson Lizardo
2011-08-11 0:26 ` Marcel Holtmann
2011-08-11 17:12 ` Andre Guedes
2011-09-05 9:03 ` Marcel Holtmann
2011-09-06 20:06 ` Andre Guedes
2011-07-25 19:50 ` [PATCH v2 12/16] Bluetooth: Report LE devices Andre Guedes
2011-07-25 19:50 ` [PATCH v2 13/16] Bluetooth: Add 'le_scan_timer' to struct hci_dev Andre Guedes
2011-07-25 19:50 ` [PATCH v2 14/16] Bluetooth: Add LE Scan helper functions Andre Guedes
2011-07-25 19:50 ` [PATCH v2 15/16] Bluetooth: Support LE-Only discovery procedure Andre Guedes
2011-08-10 13:52 ` Marcel Holtmann
2011-08-11 20:08 ` Andre Guedes
2011-09-05 9:00 ` Marcel Holtmann
2011-07-25 19:50 ` [PATCH v2 16/16] Bluetooth: Support BR/EDR/LE " Andre Guedes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312989466.3373.126.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).