Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Szymon Janc <szymon.janc@tieto.com>
Cc: linux-bluetooth@vger.kernel.org,
	par-gunnar.p.hjalmdahl@stericsson.com,
	ulrik.lauren@stericsson.com
Subject: Re: [RFC v3 1/2] Add external dummy plugin for testing
Date: Sun, 14 Aug 2011 14:12:55 -0700	[thread overview]
Message-ID: <1313356383.3373.168.camel@aeonflux> (raw)
In-Reply-To: <1313068216-16802-2-git-send-email-szymon.janc@tieto.com>

Hi Szymon,

>  Makefile.am              |    7 +++++++
>  plugins/external-dummy.c |   42 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 49 insertions(+), 0 deletions(-)
>  create mode 100644 plugins/external-dummy.c

I prefer if patches are actually tested if the apply cleanly:

Applying: Add external dummy plugin for testing
/data/devel/bluez/.git/rebase-apply/patch:30: new blank line at EOF.
+
fatal: 1 line adds whitespace errors.

Since my patch and git foo is reaching guru status, I fixed this up for
you ;)

Regards

Marcel



  reply	other threads:[~2011-08-14 21:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 13:10 [RFC v3 0/2] Fix debug messages logging from non-built-in plugins Szymon Janc
2011-08-11 13:10 ` [RFC v3 1/2] Add external dummy plugin for testing Szymon Janc
2011-08-14 21:12   ` Marcel Holtmann [this message]
2011-08-11 13:10 ` [RFC v3 2/2] Fix debug messages logging from non-built-in plugins Szymon Janc
2011-08-14 21:59   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313356383.3373.168.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=par-gunnar.p.hjalmdahl@stericsson.com \
    --cc=szymon.janc@tieto.com \
    --cc=ulrik.lauren@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox