From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] serial: Add support to Disconnect fd passing connections
Date: Tue, 23 Aug 2011 12:51:27 -0700 [thread overview]
Message-ID: <1314129089.3373.218.camel@aeonflux> (raw)
In-Reply-To: <CABBYNZLLGijC1A2MfuOKYqfiNQB=UuKsQ+awE804AkHZLfoZ4g@mail.gmail.com>
Hi Luiz,
> > This already fails today. Our code doesn't allow us to call twice the Connect
> > method, so we can't have two of the same UUID connected.
>
> Well with RFCOMM you can't really connect multiple times to the same
> channel/UUID and if we return the same fd clients will probably have
> conflicts.
you can not connect the same channel twice (except in the other
direction), that is true, but you can connect to a different channel
with a different UUID. That is the reason why we also allow connection
by handles. Or at least we should.
So even if we would make this limitation of 1 connection per UUID, the
API is a fully asymmetric then. You are suppose to disconnect with the
result of the connect call. I do not like that at all. It is bad API
design and we are trying to squeeze this in the wrong way.
Regards
Marcel
next prev parent reply other threads:[~2011-08-23 19:51 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 17:19 [PATCH 1/2] serial: add Serial.ConnectFD() Gustavo F. Padovan
2011-08-22 17:19 ` [PATCH 2/2] serial: Add support to Disconnect fd passing connections Gustavo F. Padovan
2011-08-23 16:18 ` Marcel Holtmann
2011-08-23 16:28 ` Gustavo Padovan
2011-08-23 16:30 ` Marcel Holtmann
2011-08-23 16:45 ` Gustavo Padovan
2011-08-23 18:39 ` Luiz Augusto von Dentz
2011-08-23 18:52 ` Gustavo Padovan
2011-08-23 19:51 ` Marcel Holtmann [this message]
2011-08-24 10:43 ` Luiz Augusto von Dentz
2011-08-25 14:55 ` Gustavo Padovan
2011-08-26 7:22 ` Luiz Augusto von Dentz
2011-08-26 18:16 ` Gustavo Padovan
2011-09-06 5:16 ` Gustavo Padovan
2011-09-07 7:50 ` Luiz Augusto von Dentz
2011-09-07 11:56 ` Marcel Holtmann
2011-09-07 12:09 ` Luiz Augusto von Dentz
2011-09-07 12:46 ` Marcel Holtmann
2011-09-07 15:05 ` Luiz Augusto von Dentz
2011-09-08 18:35 ` Gustavo Padovan
2011-09-07 11:54 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314129089.3373.218.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).