From: Marcel Holtmann <marcel@holtmann.org>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi,
pkrystad@codeaurora.org, andrei.emeltchenko@intel.com
Subject: Re: [PATCH 3/9] Bluetooth: Get/set AMP policy socket option
Date: Thu, 13 Oct 2011 16:27:08 -0700 [thread overview]
Message-ID: <1318548431.15441.40.camel@aeonflux> (raw)
In-Reply-To: <alpine.DEB.2.02.1110131555030.9993@mathewm-linux>
Hi Mat,
> >> Checks for valid policy value and L2CAP mode.
> >>
> >> Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
> >> ---
> >> net/bluetooth/l2cap_sock.c | 25 +++++++++++++++++++++++++
> >> 1 files changed, 25 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> >> index 836d12e..9431e38 100644
> >> --- a/net/bluetooth/l2cap_sock.c
> >> +++ b/net/bluetooth/l2cap_sock.c
> >> @@ -467,6 +467,11 @@ static int l2cap_sock_getsockopt(struct socket *sock, int level, int optname, ch
> >>
> >> break;
> >>
> >> + case BT_AMP_POLICY:
> >> + if (put_user(chan->amp_policy, (u32 __user *) optval))
> >> + err = -EFAULT;
> >
> > I prefer to not just add such an option just yet. We only want to add
> > socket option once they are functional. Otherwise we have problems to
> > detect if such an option is working or not. So enabling this option
> > should be the last patch after we have AMP implemented.
>
> My plan was to add checks for enable_hs before adding any code that
> takes action based on amp_policy. Would it be acceptable to add those
> enable_hs checks now so the code is in place, but disabled by default?
> It would be helpful for development and testing.
if it is protected enable_hs, then this is fine with me.
Regards
Marcel
next prev parent reply other threads:[~2011-10-13 23:27 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 22:00 [PATCH 0/9] AMP interface and signal framework Mat Martineau
2011-10-13 22:00 ` [PATCH 1/9] Bluetooth: Add BT_AMP_POLICY socket option Mat Martineau
2011-10-13 23:38 ` Marcel Holtmann
2011-10-14 22:38 ` Mat Martineau
2011-10-15 18:43 ` Marcel Holtmann
2011-10-17 10:25 ` Luiz Augusto von Dentz
2011-10-17 15:56 ` Marcel Holtmann
2011-10-13 22:00 ` [PATCH 2/9] Bluetooth: Add AMP policy information to l2cap_chan Mat Martineau
2011-10-14 11:20 ` Andrei Emeltchenko
2011-10-14 22:39 ` Mat Martineau
2011-10-13 22:00 ` [PATCH 3/9] Bluetooth: Get/set AMP policy socket option Mat Martineau
2011-10-13 22:35 ` Marcel Holtmann
2011-10-13 23:05 ` Mat Martineau
2011-10-13 23:27 ` Marcel Holtmann [this message]
2011-10-13 22:00 ` [PATCH 4/9] Bluetooth: Add AMP-related data and structures for channel signals Mat Martineau
2011-10-14 12:19 ` Andrei Emeltchenko
2011-10-14 22:58 ` Mat Martineau
2011-10-17 7:23 ` Andrei Emeltchenko
2011-10-13 22:00 ` [PATCH 5/9] Bluetooth: Add signal handlers for channel creation Mat Martineau
2011-10-13 22:00 ` [PATCH 6/9] Bluetooth: Add definitions for L2CAP fixed channels Mat Martineau
2011-10-13 22:00 ` [PATCH 7/9] Bluetooth: Use symbolic values for the fixed channel map Mat Martineau
2011-10-14 12:36 ` Andrei Emeltchenko
2011-10-14 23:04 ` Mat Martineau
2011-10-14 23:51 ` Gustavo Padovan
2011-10-13 22:00 ` [PATCH 8/9] Bluetooth: Add AMP header file Mat Martineau
2011-10-14 12:38 ` Andrei Emeltchenko
2011-10-14 23:07 ` Mat Martineau
2011-10-13 22:00 ` [PATCH 9/9] Bluetooth: Add signal handlers for channel moves Mat Martineau
2011-10-14 18:46 ` Gustavo Padovan
2011-10-14 23:19 ` Mat Martineau
2011-10-17 7:31 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318548431.15441.40.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andrei.emeltchenko@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mathewm@codeaurora.org \
--cc=padovan@profusion.mobi \
--cc=pkrystad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).