From: Marcel Holtmann <marcel@holtmann.org>
To: "Frédéric Danis" <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v3] fix build
Date: Mon, 17 Oct 2011 09:00:24 -0700 [thread overview]
Message-ID: <1318867227.15441.104.camel@aeonflux> (raw)
In-Reply-To: <1318866965-11091-1-git-send-email-frederic.danis@linux.intel.com>
Hi Frederic,
> src/eir.c: In function 'eir_parse':
> src/eir.c:72: error: 'name_len' may be used uninitialized in this function
>
> and
>
> thermometer/thermometer.c: In function 'destroy_char':
> thermometer/thermometer.c:79: error: implicit declaration of function 'g_slist_free_full'
please split this into two patches.
The fix for thermometer/thermometer.c is fine, but for src/eir.c I think
it is better to rewrite that function with a more clean and simpler
version.
Regards
Marcel
next prev parent reply other threads:[~2011-10-17 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 15:56 [PATCH v3] fix build Frédéric Danis
2011-10-17 16:00 ` Marcel Holtmann [this message]
2011-10-18 8:19 ` Andrei Emeltchenko
2011-10-18 16:36 ` Marcel Holtmann
2011-10-19 7:35 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318867227.15441.104.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).