From: Marcel Holtmann <marcel@holtmann.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi
Subject: Re: [PATCH 1/2] Bluetooth: Ignore hci_unregister_dev return value
Date: Wed, 26 Oct 2011 10:55:17 +0200 [thread overview]
Message-ID: <1319619318.15441.251.camel@aeonflux> (raw)
In-Reply-To: <1319618599-10938-1-git-send-email-dh.herrmann@googlemail.com>
Hi David,
> Make all bluetooth drivers ignore the return value of hci_unregister_dev as it
> always returns 0. In the next step, hci_unregister_dev can be modified to return
> void.
> Some of the drivers already ignore the return value (including btusb), hence,
> this will increase consitency in the bluetooth drivers.
>
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
> drivers/bluetooth/bfusb.c | 4 +---
> drivers/bluetooth/bluecard_cs.c | 4 +---
> drivers/bluetooth/bt3c_cs.c | 4 +---
> drivers/bluetooth/btuart_cs.c | 4 +---
> drivers/bluetooth/dtl1_cs.c | 4 +---
> drivers/bluetooth/hci_vhci.c | 5 +----
> 6 files changed, 6 insertions(+), 19 deletions(-)
I am totally fine with this.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
prev parent reply other threads:[~2011-10-26 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 8:43 [PATCH 1/2] Bluetooth: Ignore hci_unregister_dev return value David Herrmann
2011-10-26 8:43 ` [PATCH 2/2] Bluetooth: Make hci_unregister_dev return void David Herrmann
2011-10-26 8:55 ` Marcel Holtmann
2011-10-31 19:46 ` Gustavo Padovan
2011-10-26 8:55 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319619318.15441.251.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=dh.herrmann@googlemail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).