From: Marcel Holtmann <marcel@holtmann.org>
To: Mat Martineau <mathewm@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi,
pkrystad@codeaurora.org, andrei.emeltchenko@intel.com
Subject: Re: [PATCHv3 8/9] Bluetooth: Add signal handlers for channel moves
Date: Wed, 02 Nov 2011 07:25:02 +0100 [thread overview]
Message-ID: <1320215103.15441.270.camel@aeonflux> (raw)
In-Reply-To: <1320186568-25493-9-git-send-email-mathewm@codeaurora.org>
Hi Mat,
> AMP channels can be moved between BR/EDR and AMP controllers using a
> sequence of signals. Every attempted channel move involves a series of
> four signals:
<snip>
> {
> @@ -3266,6 +3390,23 @@ static inline int l2cap_bredr_sig_cmd(struct l2cap_conn *conn,
> err = l2cap_create_channel_rsp(conn, cmd, data);
> break;
>
> + case L2CAP_MOVE_CHAN_REQ:
> + err = l2cap_move_channel_req(conn, cmd, cmd_len, data);
> + break;
> +
> + case L2CAP_MOVE_CHAN_RSP:
> + err = l2cap_move_channel_rsp(conn, cmd, cmd_len, data);
> + break;
> +
> + case L2CAP_MOVE_CHAN_CFM:
> + err = l2cap_move_channel_confirm(conn, cmd, cmd_len, data);
> + break;
> +
> + case L2CAP_MOVE_CHAN_CFM_RSP:
> + err = l2cap_move_channel_confirm_rsp(conn, cmd, cmd_len, data);
> + break;
> +
> +
> default:
> BT_ERR("Unknown BR/EDR signaling command 0x%2.2x", cmd->code);
> err = -EINVAL;
and this is the coding style damage. You sneaked in two empty lines
here.
Regards
Marcel
next prev parent reply other threads:[~2011-11-02 6:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-01 22:29 [PATCHv3 0/9] AMP interface and signal framework Mat Martineau
2011-11-01 22:29 ` [PATCHv3 1/9] Bluetooth: Add BT_CHANNEL_POLICY socket option Mat Martineau
2011-11-01 22:29 ` [PATCHv3 2/9] Bluetooth: Change scope of the enable_hs module parameter Mat Martineau
2011-11-01 22:29 ` [PATCHv3 3/9] Bluetooth: Add channel policy to getsockopt/setsockopt Mat Martineau
2011-11-01 22:29 ` [PATCHv3 4/9] Bluetooth: Add AMP-related data and structures for channel signals Mat Martineau
2011-11-01 22:29 ` [PATCHv3 5/9] Bluetooth: Add signal handlers for channel creation Mat Martineau
2011-11-01 22:29 ` [PATCHv3 6/9] Bluetooth: Add definitions for L2CAP fixed channels Mat Martineau
2011-11-01 22:29 ` [PATCHv3 7/9] Bluetooth: Use symbolic values for the fixed channel map Mat Martineau
2011-11-01 22:29 ` [PATCHv3 8/9] Bluetooth: Add signal handlers for channel moves Mat Martineau
2011-11-02 6:25 ` Marcel Holtmann [this message]
2011-11-02 15:20 ` Andrei Emeltchenko
2011-11-01 22:29 ` [PATCHv3 9/9] Bluetooth: Guarantee BR-EDR device will be registered as hci0 Mat Martineau
2011-11-02 6:23 ` [PATCHv3 0/9] AMP interface and signal framework Marcel Holtmann
2011-11-02 15:21 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320215103.15441.270.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andrei.emeltchenko@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mathewm@codeaurora.org \
--cc=padovan@profusion.mobi \
--cc=pkrystad@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).