From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFCv0 19/20] Bluetooth: A2MP: handling fixed channel
Date: Wed, 2 Nov 2011 16:02:47 +0200 [thread overview]
Message-ID: <1320242568-372-20-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1320242568-372-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
A2MP fixed channel is handled differently from normal L2CAP channel.
There is no connect and config req/rsp sequence.
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
include/net/bluetooth/l2cap.h | 1 +
net/bluetooth/a2mp.c | 2 +
net/bluetooth/l2cap_core.c | 61 +++++++++++++++++++++++++++++-----------
3 files changed, 47 insertions(+), 17 deletions(-)
diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
index cc3b81f..473976e 100644
--- a/include/net/bluetooth/l2cap.h
+++ b/include/net/bluetooth/l2cap.h
@@ -559,6 +559,7 @@ enum {
FLAG_FLUSHABLE,
FLAG_EXT_CTRL,
FLAG_EFS_ENABLE,
+ FLAG_FIXED_CHANNEL,
};
#define __set_chan_timer(c, t) l2cap_set_timer(c, &c->chan_timer, (t))
diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
index 4414d74..b4d3a13 100644
--- a/net/bluetooth/a2mp.c
+++ b/net/bluetooth/a2mp.c
@@ -451,6 +451,8 @@ static void l2cap_fixed_channel_config(struct sock *sk)
lock_sock(sk);
+ set_bit(FLAG_FIXED_CHANNEL, &chan->flags);
+
chan->omtu = L2CAP_A2MP_DEFAULT_MTU;
chan->imtu = L2CAP_A2MP_DEFAULT_MTU;
chan->flush_to = L2CAP_DEFAULT_FLUSH_TO;
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 8b930ca..3dd80a5 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -316,6 +316,10 @@ static void __l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
chan->conn = conn;
+ /* Fixed channel setup is already done */
+ if (test_bit(FLAG_FIXED_CHANNEL, &chan->flags))
+ goto fixed_chan;
+
if (chan->chan_type == L2CAP_CHAN_CONN_ORIENTED) {
if (conn->hcon->type == LE_LINK) {
/* LE connection */
@@ -339,6 +343,8 @@ static void __l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan)
chan->omtu = L2CAP_DEFAULT_MTU;
}
+fixed_chan:
+
chan->local_id = L2CAP_BESTEFFORT_ID;
chan->local_stype = L2CAP_SERV_BESTEFFORT;
chan->local_msdu = L2CAP_DEFAULT_MAX_SDU_SIZE;
@@ -371,7 +377,8 @@ static void l2cap_chan_del(struct l2cap_chan *chan, int err)
chan_put(chan);
chan->conn = NULL;
- hci_conn_put(conn->hcon);
+ if (!test_bit(FLAG_FIXED_CHANNEL, &chan->flags))
+ hci_conn_put(conn->hcon);
}
l2cap_state_change(chan, BT_CLOSED);
@@ -387,7 +394,8 @@ static void l2cap_chan_del(struct l2cap_chan *chan, int err)
sk->sk_state_change(sk);
if (!(test_bit(CONF_OUTPUT_DONE, &chan->conf_state) &&
- test_bit(CONF_INPUT_DONE, &chan->conf_state)))
+ test_bit(CONF_INPUT_DONE, &chan->conf_state)) &&
+ !test_bit(FLAG_FIXED_CHANNEL, &chan->flags))
return;
skb_queue_purge(&chan->tx_q);
@@ -1128,23 +1136,34 @@ int l2cap_chan_connect(struct l2cap_chan *chan)
auth_type = l2cap_get_auth_type(chan);
- if (chan->dcid == L2CAP_CID_LE_DATA)
- hcon = hci_connect(hdev, LE_LINK, dst,
- chan->sec_level, auth_type);
- else
- hcon = hci_connect(hdev, ACL_LINK, dst,
- chan->sec_level, auth_type);
+ if (test_bit(FLAG_FIXED_CHANNEL, &chan->flags)) {
+ /* Fixed channels piggyback on existing ACL connections */
+ hcon = hci_conn_hash_lookup_ba(hdev, ACL_LINK, dst);
+ if (!hcon || !hcon->l2cap_data) {
+ err = -ENOTCONN;
+ goto done;
+ }
- if (IS_ERR(hcon)) {
- err = PTR_ERR(hcon);
- goto done;
- }
+ conn = hcon->l2cap_data;
+ } else {
+ if (chan->dcid == L2CAP_CID_LE_DATA)
+ hcon = hci_connect(hdev, LE_LINK, dst,
+ chan->sec_level, auth_type);
+ else
+ hcon = hci_connect(hdev, ACL_LINK, dst,
+ chan->sec_level, auth_type);
- conn = l2cap_conn_add(hcon, 0);
- if (!conn) {
- hci_conn_put(hcon);
- err = -ENOMEM;
- goto done;
+ if (IS_ERR(hcon)) {
+ err = PTR_ERR(hcon);
+ goto done;
+ }
+
+ conn = l2cap_conn_add(hcon, 0);
+ if (!conn) {
+ hci_conn_put(hcon);
+ err = -ENOMEM;
+ goto done;
+ }
}
/* Update source addr of the socket */
@@ -1152,6 +1171,14 @@ int l2cap_chan_connect(struct l2cap_chan *chan)
l2cap_chan_add(conn, chan);
+ if (test_bit(FLAG_FIXED_CHANNEL, &chan->flags)) {
+ l2cap_state_change(chan, BT_CONNECTED);
+ sk->sk_state = BT_CONNECTED;
+ sk->sk_state_change(sk);
+ err = 0;
+ goto done;
+ }
+
l2cap_state_change(chan, BT_CONNECT);
__set_chan_timer(chan, sk->sk_sndtimeo);
--
1.7.4.1
next prev parent reply other threads:[~2011-11-02 14:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-02 14:02 [RFCv0 00/20] RFC A2MP implementation Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 01/20] Bluetooth: A2MP: create A2MP socket Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 02/20] Bluetooth: A2MP: sk_data_ready for a2mp socket Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 03/20] Bluetooth: A2MP: sk_state_change " Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 04/20] Bluetooth: A2MP: build and send msg helpers Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 05/20] Bluetooth: A2MP: AMP Manager basic functions Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 06/20] Bluetooth: A2MP: Remove AMP manager in state_change Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 07/20] Bluetooth: A2MP: AMP manager initialization Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 08/20] Bluetooth: A2MP: Definitions for A2MP commands Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 09/20] Bluetooth: A2MP: process A2MP messages Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 10/20] Bluetooth: A2MP: processing A2MP command reject Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 11/20] Bluetooth: A2MP: helper functions to count HCI devs Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 12/20] Bluetooth: A2MP: process A2MP Discover Request Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 13/20] Bluetooth: A2MP: process A2MP Change Notify Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 14/20] Bluetooth: A2MP: process A2MP Get Info Request Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 15/20] Bluetooth: A2MP: process A2MP Get AMP Assoc Request Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 16/20] Bluetooth: A2MP: process A2MP Create Physlink Request Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 17/20] Bluetooth: A2MP: process A2MP Disc " Emeltchenko Andrei
2011-11-02 14:02 ` [RFCv0 18/20] Bluetooth: A2MP: process A2MP Command Responses Emeltchenko Andrei
2011-11-02 14:02 ` Emeltchenko Andrei [this message]
2011-11-02 14:02 ` [RFCv0 20/20] Bluetooth: A2MP: manage incoming connection Emeltchenko Andrei
2011-11-04 0:20 ` [RFCv0 00/20] RFC A2MP implementation Peter Krystad
2011-11-04 7:47 ` 'Emeltchenko Andrei'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320242568-372-20-git-send-email-Andrei.Emeltchenko.news@gmail.com \
--to=andrei.emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox