From: Marcel Holtmann <marcel@holtmann.org>
To: "Yao, Costa" <cqyao@qca.qualcomm.com>
Cc: "padovan@profusion.mobi" <padovan@profusion.mobi>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>
Subject: Re: [PATCH] Bluetooth:ath3k&btusb: Add support for Qualcomm Atheros 3006 composite device
Date: Tue, 08 Nov 2011 15:16:03 +0900 [thread overview]
Message-ID: <1320732967.15441.314.camel@aeonflux> (raw)
In-Reply-To: <07BBB2AAB1A10A488A2AD166C7CB8B0DEE9C62@nasanexd02b.na.qualcomm.com>
Hi Costa,
> From 312e18c8c46527cb7213fa57afc32094cdc9459c Mon Sep 17 00:00:00 2001
> From: Costa yao <cqyao@qca.qualcomm.com>
> Date: Thu, 3 Nov 2011 14:45:33 +0800
>
>
> AR3006 is a composite device, and interface 0 is used for hid function, not bluetooth function.
> So, we should make the following changes:
> 1 Blacklist AR3006 PID/VID in btusb and ath3k to load patch and sysconfig files
> 2 Add composite_device_table in btusb.c and ath3k_composite_device_table in ath3k.c
> to check whether it is bluetooth interface
> 3 interface 3 is used for data->isoc
please send proper formatted patch. This one is all messed up and I am
not even trying to review it.
Also split this at least into 2 patches, one for btusb.c and one for the
ath3k.c changes.
Regards
Marcel
prev parent reply other threads:[~2011-11-08 6:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-08 3:13 [PATCH] Bluetooth:ath3k&btusb: Add support for Qualcomm Atheros 3006 composite device Yao, Costa
2011-11-08 6:16 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320732967.15441.314.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=cqyao@qca.qualcomm.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).