linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Rename mgmt_inquiry_failed()
Date: Wed, 09 Nov 2011 16:38:17 +0900	[thread overview]
Message-ID: <1320824300.15441.319.camel@aeonflux> (raw)
In-Reply-To: <1320792002-31151-1-git-send-email-andre.guedes@openbossa.org>

Hi Andre,

> This patch renames the function mgmt_inquiry_failed() to
> mgmt_start_discovery_failed(). This function is more related
> to MGMT_OP_START_DISCOVERY command handling than to inquiry.
> Besides, this functions will be reused by LE based discovery
> procedures in case of failure.
> 
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
>  include/net/bluetooth/hci_core.h |    2 +-
>  net/bluetooth/hci_event.c        |    2 +-
>  net/bluetooth/mgmt.c             |    2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

the name change makes sense to be. I hope it also leads to avoiding code
duplication here in the long run.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  parent reply	other threads:[~2011-11-09  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 22:40 [PATCH 1/2] Bluetooth: Rename mgmt_inquiry_failed() Andre Guedes
2011-11-08 22:40 ` [PATCH 2/2] Bluetooth: mgmt_stop_discovery_failed() Andre Guedes
2011-11-09  7:39   ` Marcel Holtmann
2011-11-09 12:20     ` Andre Guedes
2011-11-09 14:43       ` Marcel Holtmann
2011-11-09  7:38 ` Marcel Holtmann [this message]
2011-11-09 14:40 ` [PATCH 1/2] Bluetooth: Rename mgmt_inquiry_failed() Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320824300.15441.319.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).