linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Yao, Costa" <cqyao@qca.qualcomm.com>
Cc: "padovan@profusion.mobi" <padovan@profusion.mobi>,
	"linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	"Fan, Hong" <hongfan@qca.qualcomm.com>,
	"Wu, Frank" <fanwu@qca.qualcomm.com>,
	"Chen, Jack" <skchen@qca.qualcomm.com>,
	"Chang, Robert" <rwchang@qca.qualcomm.com>,
	"Wang, Tom" <taowang@qca.qualcomm.com>,
	"Liu, Haijun" <haijun@qca.qualcomm.com>,
	"QCA.Mgr.Haijun.Liu-All" <QCA.Mgr.Haijun.Liu-All@qualcomm.com>
Subject: RE: [PATCH] Bluetooth: btusb: Add support for Qualcomm Atheros composite chip 3006
Date: Wed, 09 Nov 2011 23:41:40 +0900	[thread overview]
Message-ID: <1320849706.15441.336.camel@aeonflux> (raw)
In-Reply-To: <07BBB2AAB1A10A488A2AD166C7CB8B0DEE9DC0@nasanexd02b.na.qualcomm.com>

Hi Costa,

please do not top post on this mailing list. Otherwise I am just
ignoring your emails from the next time.

> For your first comment, 
> Yes, we can just add device with .driver_info in btusb_table, not in blacklist_table.
> 
> For your other comments,
> As the device has 4 USB interfaces and interface 2 is for Bluetooth function. We need to bypass the IF state in btusb.c as follow:
>       if (intf->cur_altsetting->desc.bInterfaceNuber !=0)
>       return -ENODEV;
>    
> So we use a composite_device_table matching mechanism and use forward jump to bypass the bInterfaceNumber check.
> And other vendors also can add their composite device in the composite_device_table to bypass the check.

And this can also be done via the .driver_info to select what interfaces
to expect. So please get rid of the composite table.

And post the content of /proc/bus/usb/devices so that I see how your
enpoints do look like.

Regards

Marcel



  reply	other threads:[~2011-11-09 14:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08  8:38 [PATCH] Bluetooth: btusb: Add support for Qualcomm Atheros composite chip 3006 Yao, Costa
2011-11-09  7:48 ` Marcel Holtmann
2011-11-09 11:30   ` Yao, Costa
2011-11-09 14:41     ` Marcel Holtmann [this message]
2011-11-10  4:50       ` Yao, Costa
2011-11-10  6:53         ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320849706.15441.336.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=QCA.Mgr.Haijun.Liu-All@qualcomm.com \
    --cc=cqyao@qca.qualcomm.com \
    --cc=fanwu@qca.qualcomm.com \
    --cc=haijun@qca.qualcomm.com \
    --cc=hongfan@qca.qualcomm.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    --cc=rwchang@qca.qualcomm.com \
    --cc=skchen@qca.qualcomm.com \
    --cc=taowang@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).