linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFCv1 10/21] Bluetooth: A2MP: Process A2MP messages
Date: Thu, 10 Nov 2011 16:54:17 +0200	[thread overview]
Message-ID: <1320936868-7978-11-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1320936868-7978-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Implement basic processing for AMP Manager Protocol (A2MP).

Example below shows processing unrecognized command.
...
> ACL data: handle 11 flags 0x02 dlen 12
    A2MP: code 0x00 ident 3 len 0
< ACL data: handle 11 flags 0x00 dlen 14
    A2MP: Command Reject: reason (0) - Command not recognized
...

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
 net/bluetooth/a2mp.c |   59 +++++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 58 insertions(+), 1 deletions(-)

diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
index 6ffdd12..4e45897 100644
--- a/net/bluetooth/a2mp.c
+++ b/net/bluetooth/a2mp.c
@@ -75,6 +75,63 @@ static void a2mp_send(struct amp_mgr *mgr, u8 code, u8 ident, u16 len,
 	kfree(cmd);
 }
 
+/* Handle A2MP signalling */
+void a2mp_receive(struct sock *sk, struct sk_buff *skb)
+{
+	struct a2mp_cmd *hdr = (struct a2mp_cmd *) skb->data;
+	struct amp_mgr *mgr;
+	int err = 0;
+
+	mgr = get_amp_mgr_sk(sk);
+	if (!mgr)
+		return;
+
+	while (skb->len >= sizeof(*hdr)) {
+		struct a2mp_cmd *hdr = (struct a2mp_cmd *) skb->data;
+		u16 len = le16_to_cpu(hdr->len);
+
+		BT_DBG("code 0x%02x id %d len %d", hdr->code, hdr->ident, len);
+
+		skb_pull(skb, sizeof(*hdr));
+
+		if (len > skb->len || !hdr->ident) {
+			err = -EINVAL;
+			break;
+		}
+
+		switch (hdr->code) {
+		case A2MP_COMMAND_REJ:
+		case A2MP_DISCOVER_REQ:
+		case A2MP_CHANGE_NOTIFY:
+		case A2MP_GETINFO_REQ:
+		case A2MP_GETAMPASSOC_REQ:
+		case A2MP_CREATEPHYSLINK_REQ:
+		case A2MP_DISCONNPHYSLINK_REQ:
+		case A2MP_CHANGE_RSP:
+		case A2MP_DISCOVER_RSP:
+		case A2MP_GETINFO_RSP:
+		case A2MP_GETAMPASSOC_RSP:
+		case A2MP_CREATEPHYSLINK_RSP:
+		case A2MP_DISCONNPHYSLINK_RSP:
+		default:
+			BT_ERR("Unknown A2MP signaling command 0x%2.2x",
+				hdr->code);
+			err = -EINVAL;
+			break;
+		}
+	}
+
+	if (err) {
+		struct a2mp_cmd_rej rej;
+		rej.reason = cpu_to_le16(0);
+
+		a2mp_send(mgr, A2MP_COMMAND_REJ, hdr->ident, sizeof(rej),
+									&rej);
+	}
+
+	amp_mgr_put(mgr);
+}
+
 static void data_ready_worker(struct work_struct *w)
 {
 	struct a2mp_work_data_ready *work = (struct a2mp_work_data_ready *) w;
@@ -85,7 +142,7 @@ static void data_ready_worker(struct work_struct *w)
 
 	/* skb_dequeue() is thread-safe */
 	while ((skb = skb_dequeue(&sk->sk_receive_queue))) {
-		/* process a2mp here */
+		a2mp_receive(sk, skb);
 		kfree_skb(skb);
 	}
 
-- 
1.7.4.1


  parent reply	other threads:[~2011-11-10 14:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 14:54 [RFCv1 00/21] RFC Bluetooth A2MP implementation Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 01/21] Bluetooth: A2MP: Create A2MP socket Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 02/21] Bluetooth: A2MP: Add sk_data_ready for " Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 03/21] Bluetooth: A2MP: Add sk_state_change " Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 04/21] Bluetooth: A2MP: Build and Send msg helpers Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 05/21] Bluetooth: A2MP: AMP Manager basic functions Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 06/21] Bluetooth: A2MP: Remove AMP manager in state_change Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 07/21] Bluetooth: A2MP: AMP manager initialization Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 08/21] Bluetooth: A2MP: Definitions for A2MP commands Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 09/21] Bluetooth: A2MP: Define A2MP status codes Emeltchenko Andrei
2011-11-10 14:54 ` Emeltchenko Andrei [this message]
2011-11-10 14:54 ` [RFCv1 11/21] Bluetooth: A2MP: Process A2MP Command Reject Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 12/21] Bluetooth: A2MP: Helper functions to count HCI devs Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 13/21] Bluetooth: A2MP: Process A2MP Discover Request Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 14/21] Bluetooth: A2MP: Process A2MP Change Notify Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 15/21] Bluetooth: A2MP: Process A2MP Get Info Request Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 16/21] Bluetooth: A2MP: Process A2MP Get AMP Assoc Request Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 17/21] Bluetooth: A2MP: Process A2MP Create Physlink Request Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 18/21] Bluetooth: A2MP: Process A2MP Disc " Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 19/21] Bluetooth: A2MP: Process A2MP Command Responses Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 20/21] Bluetooth: A2MP: Handling fixed channel Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 21/21] Bluetooth: A2MP: Manage incoming connections Emeltchenko Andrei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320936868-7978-11-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).