linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFCv1 15/21] Bluetooth: A2MP: Process A2MP Get Info Request
Date: Thu, 10 Nov 2011 16:54:22 +0200	[thread overview]
Message-ID: <1320936868-7978-16-git-send-email-Andrei.Emeltchenko.news@gmail.com> (raw)
In-Reply-To: <1320936868-7978-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>

Example of trace log for invalid controller id is shown below:
...
> ACL data: handle 11 flags 0x02 dlen 13
    A2MP: Get Info req: id 238
< ACL data: handle 11 flags 0x00 dlen 30
    A2MP: Get Info rsp: id 238 status (1) Invalid Controller ID
      total bandwidth -381650496
      max guaranteed bandwidth -274362188
      min latency -158843144
      pal capabilities 0x9750
      assoc size 49478
...
Note that If the Status field is set to Invalid Controller ID all subsequent
fields in the AMP Get Info Response shall be ignored by the receiver.

Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
 net/bluetooth/a2mp.c |   35 +++++++++++++++++++++++++++++++++++
 1 files changed, 35 insertions(+), 0 deletions(-)

diff --git a/net/bluetooth/a2mp.c b/net/bluetooth/a2mp.c
index c69e949..3cef720 100644
--- a/net/bluetooth/a2mp.c
+++ b/net/bluetooth/a2mp.c
@@ -184,6 +184,38 @@ static inline int a2mp_change_notify(struct amp_mgr *mgr, struct sk_buff *skb,
 	return 0;
 }
 
+static inline int a2mp_getinfo_req(struct amp_mgr *mgr, struct sk_buff *skb,
+							struct a2mp_cmd *hdr)
+{
+	struct a2mp_info_req *req  = (struct a2mp_info_req *)skb->data;
+	struct hci_dev *hdev;
+	struct a2mp_info_rsp rsp;
+
+	if (le16_to_cpu(hdr->len) < sizeof(*req))
+		return -EINVAL;
+
+	rsp.id = req->id;
+	rsp.status = A2MP_STATUS_INVALID_CTRL_ID;
+
+	hdev = hci_dev_get(req->id);
+	if (hdev && hdev->amp_type != HCI_BREDR) {
+		rsp.status = 0;
+		rsp.total_bw = cpu_to_le32(hdev->amp_total_bw);
+		rsp.max_bw = cpu_to_le32(hdev->amp_max_bw);
+		rsp.min_latency = cpu_to_le32(hdev->amp_min_latency);
+		rsp.pal_cap = cpu_to_le16(hdev->amp_pal_cap);
+		rsp.assoc_size = cpu_to_le16(hdev->amp_assoc_size);
+	}
+
+	if (hdev)
+		hci_dev_put(hdev);
+
+	a2mp_send(mgr, A2MP_GETINFO_RSP, hdr->ident, sizeof(rsp), &rsp);
+
+	skb_pull(skb, sizeof(*req));
+	return 0;
+}
+
 /* Handle A2MP signalling */
 void a2mp_receive(struct sock *sk, struct sk_buff *skb)
 {
@@ -222,6 +254,9 @@ void a2mp_receive(struct sock *sk, struct sk_buff *skb)
 			break;
 
 		case A2MP_GETINFO_REQ:
+			err = a2mp_getinfo_req(mgr, skb, hdr);
+			break;
+
 		case A2MP_GETAMPASSOC_REQ:
 		case A2MP_CREATEPHYSLINK_REQ:
 		case A2MP_DISCONNPHYSLINK_REQ:
-- 
1.7.4.1


  parent reply	other threads:[~2011-11-10 14:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 14:54 [RFCv1 00/21] RFC Bluetooth A2MP implementation Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 01/21] Bluetooth: A2MP: Create A2MP socket Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 02/21] Bluetooth: A2MP: Add sk_data_ready for " Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 03/21] Bluetooth: A2MP: Add sk_state_change " Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 04/21] Bluetooth: A2MP: Build and Send msg helpers Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 05/21] Bluetooth: A2MP: AMP Manager basic functions Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 06/21] Bluetooth: A2MP: Remove AMP manager in state_change Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 07/21] Bluetooth: A2MP: AMP manager initialization Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 08/21] Bluetooth: A2MP: Definitions for A2MP commands Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 09/21] Bluetooth: A2MP: Define A2MP status codes Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 10/21] Bluetooth: A2MP: Process A2MP messages Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 11/21] Bluetooth: A2MP: Process A2MP Command Reject Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 12/21] Bluetooth: A2MP: Helper functions to count HCI devs Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 13/21] Bluetooth: A2MP: Process A2MP Discover Request Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 14/21] Bluetooth: A2MP: Process A2MP Change Notify Emeltchenko Andrei
2011-11-10 14:54 ` Emeltchenko Andrei [this message]
2011-11-10 14:54 ` [RFCv1 16/21] Bluetooth: A2MP: Process A2MP Get AMP Assoc Request Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 17/21] Bluetooth: A2MP: Process A2MP Create Physlink Request Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 18/21] Bluetooth: A2MP: Process A2MP Disc " Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 19/21] Bluetooth: A2MP: Process A2MP Command Responses Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 20/21] Bluetooth: A2MP: Handling fixed channel Emeltchenko Andrei
2011-11-10 14:54 ` [RFCv1 21/21] Bluetooth: A2MP: Manage incoming connections Emeltchenko Andrei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320936868-7978-16-git-send-email-Andrei.Emeltchenko.news@gmail.com \
    --to=andrei.emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).