linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Gix <bgix@codeaurora.org>
To: linux-bluetooth@vger.kernel.org,
	Gustavo Padovan <padovan@profusion.mobi>
Subject: [PATCH 0/3] Bluetooth: Add Passkey Entry and User Confirm hooks for SMP
Date: Thu, 10 Nov 2011 12:52:52 -0800	[thread overview]
Message-ID: <1320958375-24425-1-git-send-email-bgix@codeaurora.org> (raw)

While I actually prefer Johan's method of adding the User Confirm MGMT code,
with it's code re-use between user_confirm_reply, and user_confirm_neg_reply,
I have broken the user_passkey_reply out from user_passkey_neg_reply, and
added an additional patch to hook in the HCI/SSP based usage of passkeys.

This makes sense, I suppose, since the regular and neg replies for passkeys
are different sizes.

Passkey's only come into play only if our OI_CAP happens to be
KeyboardOnly (for BR/EDR/LER) or DisplayKeyboard (LE only).

So the summary of the changes is:

1. Addition of BR/EDR vs LE breakout in user_confirm_reply
	1.1 Adds SMP placeholder
	1.2 Keeps Johan's confirm_reply & confirm_neg_reply structure.
		1.2.1 Johan can defend or change that himself, but the existing code works.

2. Addition of user_passkey_reply, with both BR/EDR (SSP) and LE (SMP) handling
	2.1 Adds approriate SSP HCI opcodes
	2.2 Adds appropriate MGMT opcodes
	2.3 Adds SMP placeholder
	2.4 Seperate paths for passkey_reply & passkey_neg_reply

3. Addition of HCI event handling and forwarding for the appropriate BR/EDR SSP events


-- 
Brian Gix
bgix@codeaurora.org
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum 


             reply	other threads:[~2011-11-10 20:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-10 20:52 Brian Gix [this message]
2011-11-10 20:52 ` [PATCH 1/3] Bluetooth: Add SMP support to user_confirm_reply Brian Gix
2011-11-16 17:54   ` Gustavo Padovan
2011-11-10 20:52 ` [PATCH 2/3] Bluetooth: Add MGMT opcode for User Passkey entry Brian Gix
2011-11-16 17:55   ` Gustavo Padovan
2011-11-10 20:52 ` [PATCH 3/3] Bluetooth: Add User Passkey entry to HCI Events Brian Gix

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320958375-24425-1-git-send-email-bgix@codeaurora.org \
    --to=bgix@codeaurora.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).