Re: [RFC 2/2] Bluetooth: Do not set HCI_RAW when HS enabled

[Marcel Holtmann <marcel@holtmann.org>]

Hi Andrei,

>  net/bluetooth/hci_core.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 189bada..1b08e4b 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -51,6 +51,7 @@
>  
>  #include <net/bluetooth/bluetooth.h>
>  #include <net/bluetooth/hci_core.h>
> +#include <net/bluetooth/l2cap.h>
>  
>  #define AUTO_OFF_TIMEOUT 2000
>  
> @@ -570,8 +571,9 @@ int hci_dev_open(__u16 dev)
>  	if (test_bit(HCI_QUIRK_RAW_DEVICE, &hdev->quirks))
>  		set_bit(HCI_RAW, &hdev->flags);
>  
> -	/* Treat all non BR/EDR controllers as raw devices for now */
> -	if (hdev->dev_type != HCI_BREDR)
> +	/* Treat all non BR/EDR controllers as raw devices if
> +	   enable_hs is not set */
> +	if (hdev->dev_type != HCI_BREDR && !enable_hs)
>  		set_bit(HCI_RAW, &hdev->flags);

this is fine with me. Even while the include of l2cap.h is kinda nasty.
Maybe the enable_hs variable actually needs to be moved into hci_*.c
files and not stay inside L2CAP.

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel