From: Marcel Holtmann <marcel@holtmann.org>
To: Brian Gix <bgix@codeaurora.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/5] Bluetooth: Cleanup blkcipher on SMP termination
Date: Sat, 12 Nov 2011 16:01:50 +0900 [thread overview]
Message-ID: <1321081314.15441.432.camel@aeonflux> (raw)
In-Reply-To: <1321057441-7921-5-git-send-email-bgix@codeaurora.org>
Hi Brian,
> Signed-off-by: Brian Gix <bgix@codeaurora.org>
> ---
> net/bluetooth/smp.c | 8 +++++++-
> 1 files changed, 7 insertions(+), 1 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
But please get into the habit of having proper commit messages with
explanation.
I wanna be able to read the commit message and then compare that the
code does exactly what you claim it to be doing.
Regards
Marcel
next prev parent reply other threads:[~2011-11-12 7:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 0:23 [PATCH 0/5] Bluetooth: Add MITM protection to SMP Brian Gix
2011-11-12 0:23 ` [PATCH 1/5] Bluetooth: Add SMP support to user_confirm_reply Brian Gix
2011-11-12 6:52 ` Marcel Holtmann
2011-11-12 0:23 ` [PATCH 2/5] Bluetooth: Add MGMT opcode for User Passkey entry Brian Gix
2011-11-12 6:57 ` Marcel Holtmann
2011-11-12 0:23 ` [PATCH 3/5] Bluetooth: Add User Passkey entry to HCI Events Brian Gix
2011-11-12 6:59 ` Marcel Holtmann
2011-11-12 9:29 ` Johan Hedberg
2011-11-12 0:24 ` [PATCH 4/5] Bluetooth: Cleanup blkcipher on SMP termination Brian Gix
2011-11-12 7:01 ` Marcel Holtmann [this message]
2011-11-12 0:24 ` [PATCH 5/5] Bluetooth: Add support for MITM LE-SMP pairing Brian Gix
2011-11-12 23:12 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321081314.15441.432.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=bgix@codeaurora.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox