From: Marcel Holtmann <marcel@holtmann.org>
To: Alon Bar-Lev <alon.barlev@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Automake AM_CFLAGS, AM_LDFLAGS fixups
Date: Sun, 13 Nov 2011 13:50:49 +0900 [thread overview]
Message-ID: <1321159852.15441.449.camel@aeonflux> (raw)
In-Reply-To: <1321141730-20943-2-git-send-email-alon.barlev@gmail.com>
Hi Alon,
> Reference: "Flag Variables Ordering"[1]
>
> In automake, if you modify CFLAGS or LDFLAGS of a target you
> actually override the autoconf supplied flags. This is highly
> none standard and may lead to undesired results, as some
> targets will be compiled with the autoconf supplied flags and
> some won't.
>
> This patch adds AM_LDFLAGS to any flags overridden.
care to redo this against latest GIT tree and please use a proper commit
message target for LDFLAGS and not just copy&paste.
Regards
Marcel
next prev parent reply other threads:[~2011-11-13 4:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-12 23:48 [PATCH 1/2] Automake AM_CFLAGS, AM_LDFLAGS fixups Alon Bar-Lev
2011-11-12 23:48 ` [PATCH 2/2] " Alon Bar-Lev
2011-11-13 4:50 ` Marcel Holtmann [this message]
2011-11-13 7:40 ` [PATCH] Automake - do not override LDFLAGS Alon Bar-Lev
2011-11-16 18:38 ` Alon Bar-Lev
2011-11-13 4:49 ` [PATCH 1/2] Automake AM_CFLAGS, AM_LDFLAGS fixups Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321159852.15441.449.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=alon.barlev@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox