From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH BlueZ 2/2] rctest: fix not setting priority of accepted socket
Date: Tue, 15 Nov 2011 13:06:24 +0200 [thread overview]
Message-ID: <1321355184-24628-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1321355184-24628-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
SO_PRIORITY is not inherited upon accept so it has to be set manually in
the new socket.
---
test/rctest.c | 15 ++++++++-------
1 files changed, 8 insertions(+), 7 deletions(-)
diff --git a/test/rctest.c b/test/rctest.c
index b8acfb7..4d7c90a 100644
--- a/test/rctest.c
+++ b/test/rctest.c
@@ -312,13 +312,6 @@ static void do_listen(void (*handler)(int sk))
goto error;
}
- if (priority > 0 && setsockopt(sk, SOL_SOCKET, SO_PRIORITY, &priority,
- sizeof(priority)) < 0) {
- syslog(LOG_ERR, "Can't set socket priority: %s (%d)",
- strerror(errno), errno);
- goto error;
- }
-
/* Listen for connections */
if (listen(sk, 10)) {
syslog(LOG_ERR,"Can not listen on the socket: %s (%d)",
@@ -369,6 +362,14 @@ static void do_listen(void (*handler)(int sk))
//goto error;
}
+ if (priority > 0 && setsockopt(sk, SOL_SOCKET, SO_PRIORITY,
+ &priority, sizeof(priority)) < 0) {
+ syslog(LOG_ERR, "Can't set socket priority: %s (%d)",
+ strerror(errno), errno);
+ close(nsk);
+ goto error;
+ }
+
optlen = sizeof(priority);
if (getsockopt(nsk, SOL_SOCKET, SO_PRIORITY, &opt, &optlen) < 0) {
syslog(LOG_ERR, "Can't get socket priority: %s (%d)",
--
1.7.7.1
next prev parent reply other threads:[~2011-11-15 11:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-15 11:06 [PATCH BlueZ 1/2] l2test: fix not setting priority of accepted socket Luiz Augusto von Dentz
2011-11-15 11:06 ` Luiz Augusto von Dentz [this message]
2011-11-16 13:30 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321355184-24628-2-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).