Re: [PATCHv3 1/3] Bluetooth: Allow to set AMP type for virtual HCI

[Marcel Holtmann <marcel@holtmann.org>]

Hi Andrei,

> > Type can be changed during re-opening device /dev/vhci.
> > 
> > Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> > Acked-by: Marcel Holtmann <marcel@holtmann.org>
> > ---
> >  drivers/bluetooth/hci_vhci.c |    8 ++++++++
> >  1 files changed, 8 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/bluetooth/hci_vhci.c b/drivers/bluetooth/hci_vhci.c
> > index 2e302a1..2ed6ab1 100644
> > --- a/drivers/bluetooth/hci_vhci.c
> > +++ b/drivers/bluetooth/hci_vhci.c
> > @@ -41,6 +41,8 @@
> >  
> >  #define VERSION "1.3"
> >  
> > +static bool amp;
> > +
> >  struct vhci_data {
> >  	struct hci_dev *hdev;
> >  
> > @@ -239,6 +241,9 @@ static int vhci_open(struct inode *inode, struct file *file)
> >  	hdev->bus = HCI_VIRTUAL;
> >  	hdev->driver_data = data;
> >  
> > +	if (amp)
> > +		hdev->dev_type = HCI_AMP;
> > +
> 
> I am thinking about changing lines above to:
> 
> -       if (amp)
> +       if (amp) {
>                 hdev->dev_type = HCI_AMP;
> +               hdev->amp_type = AMP_CTRL_BLUETOOTH_ONLY;
> +       }
> 
> to indicate that that "the AMP Controller is only used by the Bluetooth
> technology and will not be shared with other non-Bluetooth technologies".

this can not be static information at this point. It will change
depending on how the WiFi subsystem or WiFi drivers want it to be.

And lets cross the bridge when we get to it. This is too early to figure
out what to do here.

Regards

Marcel