Re: [PATCH] Bluetooth: btusb: Use USB_INTERFACE_INFO to do device matching

[Marcel Holtmann <marcel@holtmann.org>]

Hi Costa,

> 1 Use USB_INTERFACE_INFO to do device matching, other than USB_DEVICE_INFO.
> 2 Delete desc.bInterfaceNumber != 0 check.
> 
> Signed-off-by: Costa Yao <cqyao@qca.qualcomm.com>
> ---
>  drivers/bluetooth/btusb.c |   16 ++++++++--------
>  1 files changed, 8 insertions(+), 8 deletions(-)

this looks fine to me now. And isn't this a much cleaner patch ;)

> -	/* Interface numbers are hardcoded in the specification */
> -	data->isoc = usb_ifnum_to_if(data->udev, 1);
> +	/* According to HCI-USB specification, the interface for
> +	 * SCO data endpoint follows the interface for commands,
> +	 * events and ACL data
> +	 */

Minor nitpick here. It is SCO data endpoints (plural). Just resend the
patch with this fixed and feel free to add my ACK.

> +	data->isoc = usb_ifnum_to_if(data->udev,
> +		intf->cur_altsetting->desc.bInterfaceNumber + 1);
>  
>  	if (!reset)
>  		set_bit(HCI_QUIRK_NO_RESET, &hdev->quirks);

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel