From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 1/9] Bluetooth: Add dev_flags to struct hci_dev
Date: Mon, 28 Nov 2011 17:17:09 +0100 [thread overview]
Message-ID: <1322497029.29909.30.camel@aeonflux> (raw)
In-Reply-To: <1322265226-6404-2-git-send-email-andre.guedes@openbossa.org>
Hi Andre,
> This patch adds the dev_flags field to struct hci_dev. This new
> flags variable should be used to define flags related to BR/EDR
> and/or LE controller itself. It should be used to define flags
> which represents states from the controller. The dev_flags is
> cleared in case the controller sends a Reset Command Complete
> Event to the host.
>
> Also, this patch adds the HCI_LE_SCAN flag which was created to
> track if the controller is performing LE scan or not. The flag
> is set/cleared when the controller starts/stops scanning.
>
> This is an initial effort to stop using hdev->flags to define
> internal flags since it is exported to userspace by an ioctl.
>
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
> include/net/bluetooth/hci.h | 8 ++++++++
> include/net/bluetooth/hci_core.h | 2 ++
> net/bluetooth/hci_core.c | 1 +
> net/bluetooth/hci_event.c | 6 ++++++
> 4 files changed, 17 insertions(+), 0 deletions(-)
looks good to me.
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2011-11-28 16:17 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 23:53 [PATCH v2 0/9] LE-Only discovery procedure support Andre Guedes
2011-11-25 23:53 ` [PATCH v2 1/9] Bluetooth: Add dev_flags to struct hci_dev Andre Guedes
2011-11-28 16:17 ` Marcel Holtmann [this message]
2011-11-25 23:53 ` [PATCH v2 2/9] Bluetooth: LE Set Scan Parameter Command Andre Guedes
2011-11-28 16:17 ` Marcel Holtmann
2011-12-02 12:19 ` Gustavo Padovan
2011-11-25 23:53 ` [PATCH v2 3/9] Bluetooth: Add helper functions to send LE scan commands Andre Guedes
2011-11-28 16:19 ` Marcel Holtmann
2011-11-25 23:53 ` [PATCH v2 4/9] Bluetooth: Add structs to implement LE scan Andre Guedes
2011-11-25 23:53 ` [PATCH v2 5/9] Bluetooth: LE scan infra-structure Andre Guedes
2011-11-28 16:24 ` Marcel Holtmann
2011-11-30 18:11 ` Andre Guedes
2011-12-02 10:02 ` Query on Media Interface "RegisterPlayer" and Dbus signal "TrackChanged" Jaganath
2011-12-02 11:07 ` Luiz Augusto von Dentz
2011-12-05 13:03 ` sathish
2011-12-06 6:21 ` Chethan T N
2011-11-25 23:53 ` [PATCH v2 6/9] Bluetooth: Add LE scan functions to hci_core Andre Guedes
2011-11-28 16:28 ` Marcel Holtmann
2011-11-30 18:11 ` Andre Guedes
2011-11-25 23:53 ` [PATCH v2 7/9] Bluetooth: Add 'eir_len' param to mgmt_device_found() Andre Guedes
2011-11-27 6:37 ` Ganir, Chen
2011-11-28 11:08 ` Anderson Lizardo
2011-11-28 14:06 ` Andre Guedes
2011-11-25 23:53 ` [PATCH v2 8/9] Bluetooth: Report LE devices Andre Guedes
2011-11-25 23:53 ` [PATCH v2 9/9] Bluetooth: Support LE-Only discovery procedure Andre Guedes
2011-11-27 6:44 ` Ganir, Chen
2011-11-28 14:51 ` Andre Guedes
2011-11-29 9:14 ` Johan Hedberg
2011-11-30 6:43 ` Ganir, Chen
2011-11-30 11:27 ` Johan Hedberg
2011-11-30 11:38 ` Ganir, Chen
2011-11-30 11:44 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322497029.29909.30.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=andre.guedes@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).