From: Marcel Holtmann <marcel@holtmann.org>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv3 3/3] Bluetooth: trivial: correct check for LMP version
Date: Wed, 30 Nov 2011 15:13:17 +0100 [thread overview]
Message-ID: <1322662397.26198.0.camel@aeonflux> (raw)
In-Reply-To: <1322642695-5784-4-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> Make sure that code match exactly what comment says about pre 1.2
> LMP version.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/hci_event.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
>
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index 60651fa..27b1ede 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -498,7 +498,7 @@ static void hci_setup_event_mask(struct hci_dev *hdev)
>
> /* CSR 1.1 dongles does not accept any bitfield so don't try to set
> * any event mask for pre 1.2 devices */
> - if (hdev->lmp_ver <= BLUETOOTH_VER_1_1)
> + if (hdev->lmp_ver < BLUETOOTH_VER_1_2)
> return;
However, even here you need to use hci_ver since it is a HCI detail and
has nothing to do with the LMP version.
Regards
Marcel
next prev parent reply other threads:[~2011-11-30 14:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 8:44 [PATCHv3 0/3] Bluetooth trivial version fixes Emeltchenko Andrei
2011-11-30 8:44 ` [PATCHv3 1/3] Bluetooth: Correct version check in hci_setup Emeltchenko Andrei
2011-11-30 8:44 ` [PATCHv3 2/3] Bluetooth: Remove magic bluetooth version numbers Emeltchenko Andrei
2011-11-30 8:44 ` [PATCHv3 3/3] Bluetooth: trivial: correct check for LMP version Emeltchenko Andrei
2011-11-30 14:13 ` Marcel Holtmann [this message]
2011-11-30 14:27 ` Emeltchenko Andrei
2011-11-30 14:33 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322662397.26198.0.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox