From: Marcel Holtmann <marcel@holtmann.org>
To: Gustavo Padovan <padovan@profusion.mobi>
Cc: johan.hedberg@gmail.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: Ignore HCI_Read_Local_Commands failures
Date: Fri, 02 Dec 2011 16:26:47 +0100 [thread overview]
Message-ID: <1322839607.26198.36.camel@aeonflux> (raw)
In-Reply-To: <20111202000247.GB2688@joana>
Hi Gustavo,
> > > > Some 1.2 controllers will fail the HCI_Read_Local_Commands HCI command
> > > > even though (according to the specification) they should support it.
> > > > Since this HCI command is part of the controller init sequence
> > > > controllers broken in this manner would be unusable. Since not having
> > > > the list of supported commands is not critical for these controllers it
> > > > is better to just ignore failures in this case (additionally, this is
> > > > also how older kernels used to behave).
> > > >
> > > > Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> > > > ---
> > > > net/bluetooth/hci_event.c | 16 ++++++++++++++++
> > > > 1 files changed, 16 insertions(+), 0 deletions(-)
> > >
> > > Both patches have been applied, thanks.
> >
> > I would have preferred you didn't. Since now I have to get this all
> > fixed up as well.
>
> Is this for both of them?
yes, we need to stop hacking around here and once and for all solve this
properly.
Regards
Marcel
next prev parent reply other threads:[~2011-12-02 15:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-21 18:01 [PATCH 1/2] Bluetooth: Fix request completion for command status events johan.hedberg
2011-11-21 18:01 ` [PATCH 2/2] Bluetooth: Ignore HCI_Read_Local_Commands failures johan.hedberg
2011-12-01 12:40 ` Gustavo Padovan
2011-12-01 13:09 ` Marcel Holtmann
2011-12-02 0:02 ` Gustavo Padovan
2011-12-02 15:26 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-21 15:18 [PATCH 1/2] Bluetooth: Fix request completion for command status events johan.hedberg
2011-11-21 15:19 ` [PATCH 2/2] Bluetooth: Ignore HCI_Read_Local_Commands failures johan.hedberg
2011-11-21 16:44 ` Marcel Holtmann
2011-11-21 18:04 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322839607.26198.36.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).