From: Marcel Holtmann <marcel@holtmann.org>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv1 5/6] Bluetooth: Correct packet len calculation
Date: Thu, 08 Dec 2011 16:54:43 +0200 [thread overview]
Message-ID: <1323356083.1965.43.camel@aeonflux> (raw)
In-Reply-To: <1323348786-18134-6-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> Remove unneeded skb_pull and correct packet length calculation
> removing magic number. Move BT_DBG after len check otherwise
> it could possibly access wrong memory.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/hci_event.c | 9 ++++-----
> 1 files changed, 4 insertions(+), 5 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2011-12-08 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 12:53 [PATCHv1 0/6] Implement basic HCI block-based flow control Emeltchenko Andrei
2011-12-08 12:53 ` [PATCHv1 1/6] Bluetooth: Add HCI Read Data Block Size function Emeltchenko Andrei
2011-12-08 12:53 ` [PATCHv1 2/6] Bluetooth: Simplify num_comp_pkts_evt function Emeltchenko Andrei
2011-12-08 12:53 ` [PATCHv1 3/6] Bluetooth: Check for flow control mode Emeltchenko Andrei
2011-12-18 23:47 ` Gustavo Padovan
2011-12-18 23:55 ` Gustavo Padovan
2011-12-08 12:53 ` [PATCHv1 4/6] Bluetooth: Clean up magic pointers Emeltchenko Andrei
2011-12-08 12:53 ` [PATCHv1 5/6] Bluetooth: Correct packet len calculation Emeltchenko Andrei
2011-12-08 14:54 ` Marcel Holtmann [this message]
2011-12-08 12:53 ` [PATCHv1 6/6] Bluetooth: Process num completed data blocks event Emeltchenko Andrei
2011-12-08 14:55 ` Marcel Holtmann
2011-12-08 14:56 ` [PATCHv1 0/6] Implement basic HCI block-based flow control Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323356083.1965.43.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).