Linux bluetooth development
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH 3/4] a2dp: return NotSupported error if no server found
Date: Thu, 15 Dec 2011 11:01:06 +0100	[thread overview]
Message-ID: <1323943267-14576-4-git-send-email-mikel.astiz.oss@gmail.com> (raw)
In-Reply-To: <1323943267-14576-1-git-send-email-mikel.astiz.oss@gmail.com>

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

With both sink and sources disabled, the A2DP server is not even
registered in audio_manager_init. When trying to register the endpoint,
this should result in the same error as if the server existed but the
profile was disabled.
---
 audio/a2dp.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/audio/a2dp.c b/audio/a2dp.c
index 5ca105c..9ed2ebb 100644
--- a/audio/a2dp.c
+++ b/audio/a2dp.c
@@ -1590,7 +1590,7 @@ struct a2dp_sep *a2dp_add_sep(const bdaddr_t *src, uint8_t type,
 	server = find_server(servers, src);
 	if (server == NULL) {
 		if (err)
-			*err = -EINVAL;
+			*err = -EPROTONOSUPPORT;
 		return NULL;
 	}
 
-- 
1.7.6.4


  parent reply	other threads:[~2011-12-15 10:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-15 10:01 [PATCH 0/4] Minor audio-related fixes Mikel Astiz
2011-12-15 10:01 ` [PATCH 1/4] audio: remove unnecessary method call Mikel Astiz
2011-12-15 11:46   ` Luiz Augusto von Dentz
2011-12-30 11:16     ` Johan Hedberg
2011-12-15 10:01 ` [PATCH 2/4] audio: gateway_unlock together with in_use = FALSE Mikel Astiz
2011-12-15 11:48   ` Luiz Augusto von Dentz
2011-12-15 10:01 ` Mikel Astiz [this message]
2011-12-15 11:49   ` [PATCH 3/4] a2dp: return NotSupported error if no server found Luiz Augusto von Dentz
2011-12-15 10:01 ` [PATCH 4/4] audio: do not disconnect on gateway SCO failure Mikel Astiz
2011-12-15 11:51   ` Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323943267-14576-4-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox