Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Albert Pool <albertpool@solcon.nl>
Cc: padovan@profusion.mobi, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Add USB ID of HP's Broadcom BCM2035 Bluetooth
Date: Fri, 23 Dec 2011 09:06:51 -0800	[thread overview]
Message-ID: <1324660011.1965.260.camel@aeonflux> (raw)
In-Reply-To: <1324636919.2912.0.camel@albert-ASUSTeK-P4P800SE>

Hi Albert,

> Add USB ID of HP's Broadcom BCM2035 Bluetooth 03f0:011d
> 
> Signed-off-by: Albert Pool <albertpool@solcon.nl> 
> - - - 
> With this patch the Bluetooth device of the HP Compaq nc6120 is able to pair to other devices.
> I've also tried using BTUSB_WRONG_SCO_MTU, but with that setting it often failed to enable the device.
> 
> From usb-devices:
> T:  Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#=  2 Spd=12  MxCh= 0
> D:  Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs=  1
> P:  Vendor=03f0 ProdID=011d Rev=00.17
> S:  Manufacturer=Broadcom
> S:  Product=HP integrated Bluetooth module
> C:  #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA
> I:  If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I:  If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> I:  If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I:  If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=00 Driver=(none)

both comments can go into the commit message (above ---). Just the "I
don't know if this patch is correct" thing is a comment that should have
been here.

> 
> --- a/drivers/bluetooth/btusb.c 
> +++ b/drivers/bluetooth/btusb.c 
> @@ -142,7 +142,8 @@ static struct usb_device_id blacklist_ta 
>  	{ USB_DEVICE(0x0a5c, 0x201e), .driver_info = BTUSB_WRONG_SCO_MTU }, 
>  	{ USB_DEVICE(0x0a5c, 0x2110), .driver_info = BTUSB_WRONG_SCO_MTU }, 
>  
> -	/* HP laptop with Broadcom chip */ 
> +	/* HP laptops with Broadcom chip */ 
> +	{ USB_DEVICE(0x03f0, 0x011d), .driver_info = BTUSB_BCM92035 }, 
>  	{ USB_DEVICE(0x03f0, 0x171d), .driver_info = BTUSB_WRONG_SCO_MTU }, 
>  
>  	/* Dell laptop with Broadcom chip */ 

Regards

Marcel



      reply	other threads:[~2011-12-23 17:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-23 10:41 [PATCH v2] Add USB ID of HP's Broadcom BCM2035 Bluetooth Albert Pool
2011-12-23 17:06 ` Marcel Holtmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1324660011.1965.260.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=albertpool@solcon.nl \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=padovan@profusion.mobi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox