[RFC BlueZ 0/1] Add provision for terminating an ATT connection

[RFC BlueZ 0/1] Add provision for terminating an ATT connection

[smriti]

The disconnect function was needed in order to terminate any existing
ATT connection from the client side. 

smriti (1):
  Add provision for terminating an ATT connection

 src/device.c |   14 ++++++++++++++
 src/device.h |    1 +
 2 files changed, 15 insertions(+), 0 deletions(-)

[RFC BlueZ 1/1] Add provision for terminating an ATT connection

[smriti]

This patch adds a function for disconnecting an ATT connection
from the client side.
---
 src/device.c |   14 ++++++++++++++
 src/device.h |    1 +
 2 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/src/device.c b/src/device.c
index e49e9bc..552df6e 100644
--- a/src/device.c
+++ b/src/device.c
@@ -2880,3 +2880,17 @@ gboolean btd_device_remove_attio_callback(struct btd_device *device, guint id)
 
 	return TRUE;
 }
+
+void att_disconnect(struct btd_device *device)
+{
+	GIOChannel *io;
+
+	if (!device)
+		return;
+
+	io = g_attrib_get_channel(device->attrib);
+	if (io) {
+		g_io_channel_shutdown(io, FALSE, NULL);
+		g_io_channel_unref(io);
+	}
+}
diff --git a/src/device.h b/src/device.h
index 13005ae..bd14315 100644
--- a/src/device.h
+++ b/src/device.h
@@ -119,3 +119,4 @@ int device_block(DBusConnection *conn, struct btd_device *device,
 						gboolean update_only);
 int device_unblock(DBusConnection *conn, struct btd_device *device,
 					gboolean silent, gboolean update_only);
+void att_disconnect(struct btd_device *device);
\ No newline at end of file
-- 
1.7.0.4

RE: [RFC BlueZ 1/1] Add provision for terminating an ATT connection

[Smriti GUPTA]

Hi Johan,

Do you have any comments on the below patch.


-----Original Message-----
From: Smriti GUPTA 
Sent: Monday, December 26, 2011 3:46 PM
To: linux-bluetooth@vger.kernel.org
Cc: Naresh-kumar GUPTA; Smriti GUPTA
Subject: [RFC BlueZ 1/1] Add provision for terminating an ATT connection

This patch adds a function for disconnecting an ATT connection
from the client side.
---
 src/device.c |   14 ++++++++++++++
 src/device.h |    1 +
 2 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/src/device.c b/src/device.c
index e49e9bc..552df6e 100644
--- a/src/device.c
+++ b/src/device.c
@@ -2880,3 +2880,17 @@ gboolean btd_device_remove_attio_callback(struct btd_device *device, guint id)
 
 	return TRUE;
 }
+
+void att_disconnect(struct btd_device *device)
+{
+	GIOChannel *io;
+
+	if (!device)
+		return;
+
+	io = g_attrib_get_channel(device->attrib);
+	if (io) {
+		g_io_channel_shutdown(io, FALSE, NULL);
+		g_io_channel_unref(io);
+	}
+}
diff --git a/src/device.h b/src/device.h
index 13005ae..bd14315 100644
--- a/src/device.h
+++ b/src/device.h
@@ -119,3 +119,4 @@ int device_block(DBusConnection *conn, struct btd_device *device,
 						gboolean update_only);
 int device_unblock(DBusConnection *conn, struct btd_device *device,
 					gboolean silent, gboolean update_only);
+void att_disconnect(struct btd_device *device);
\ No newline at end of file
-- 
1.7.0.4

Regards,
Smriti

Re: [RFC BlueZ 1/1] Add provision for terminating an ATT connection

[Johan Hedberg]

Hi,

On Thu, Jan 19, 2012, Smriti GUPTA wrote:
> Do you have any comments on the below patch.

Sure,

> --- a/src/device.c
> +++ b/src/device.c
> @@ -2880,3 +2880,17 @@ gboolean btd_device_remove_attio_callback(struct btd_device *device, guint id)
>  
>  	return TRUE;
>  }
> +
> +void att_disconnect(struct btd_device *device)
> +{
> +	GIOChannel *io;
> +
> +	if (!device)
> +		return;
> +
> +	io = g_attrib_get_channel(device->attrib);
> +	if (io) {
> +		g_io_channel_shutdown(io, FALSE, NULL);
> +		g_io_channel_unref(io);
> +	}
> +}
> diff --git a/src/device.h b/src/device.h
> index 13005ae..bd14315 100644
> --- a/src/device.h
> +++ b/src/device.h
> @@ -119,3 +119,4 @@ int device_block(DBusConnection *conn, struct btd_device *device,
>  						gboolean update_only);
>  int device_unblock(DBusConnection *conn, struct btd_device *device,
>  					gboolean silent, gboolean update_only);
> +void att_disconnect(struct btd_device *device);

I don't think any separate function like this should be needed. Instead,
the existing device_request_disconnect() function should be extended
take care of bringing down any ATT connections.

Johan

RE: [RFC BlueZ 1/1] Add provision for terminating an ATT connection

[Smriti GUPTA]

Hi Johan,

-----Original Message-----
From: Johan Hedberg [mailto:johan.hedberg@gmail.com] 
Sent: Thursday, January 19, 2012 1:27 PM
To: Smriti GUPTA
Cc: Naresh-kumar GUPTA; smritigupta2008@gmail.com; linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ 1/1] Add provision for terminating an ATT connection

Hi,

On Thu, Jan 19, 2012, Smriti GUPTA wrote:
> Do you have any comments on the below patch.

Sure,

> --- a/src/device.c
> +++ b/src/device.c
> @@ -2880,3 +2880,17 @@ gboolean btd_device_remove_attio_callback(struct btd_device *device, guint id)
>  
>  	return TRUE;
>  }
> +
> +void att_disconnect(struct btd_device *device)
> +{
> +	GIOChannel *io;
> +
> +	if (!device)
> +		return;
> +
> +	io = g_attrib_get_channel(device->attrib);
> +	if (io) {
> +		g_io_channel_shutdown(io, FALSE, NULL);
> +		g_io_channel_unref(io);
> +	}
> +}
> diff --git a/src/device.h b/src/device.h
> index 13005ae..bd14315 100644
> --- a/src/device.h
> +++ b/src/device.h
> @@ -119,3 +119,4 @@ int device_block(DBusConnection *conn, struct btd_device *device,
>  						gboolean update_only);
>  int device_unblock(DBusConnection *conn, struct btd_device *device,
>  					gboolean silent, gboolean update_only);
> +void att_disconnect(struct btd_device *device);

I don't think any separate function like this should be needed. Instead,
the existing device_request_disconnect() function should be extended
take care of bringing down any ATT connections.
Thanks for your suggestions.
I have uploaded a new patch, please have a look.

Johan

Regards,
Smriti