Linux bluetooth development
 help / color / mirror / Atom feed
From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: linux-bluetooth@vger.kernel.org
Cc: "Gustavo F. Padovan" <padovan@profusion.mobi>
Subject: [PATCH 4/5] Bluetooth: Remove local_bh_disable() from hci_sock.c
Date: Tue, 27 Dec 2011 15:28:47 -0200	[thread overview]
Message-ID: <1325006928-3338-4-git-send-email-padovan@profusion.mobi> (raw)
In-Reply-To: <1325006928-3338-3-git-send-email-padovan@profusion.mobi>

From: "Gustavo F. Padovan" <padovan@profusion.mobi>

Everything is in process context now, we do not need such a call.

Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
---
 net/bluetooth/hci_sock.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index 189a667..896a72f 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -767,7 +767,6 @@ static int hci_sock_dev_event(struct notifier_block *this, unsigned long event,
 		/* Detach sockets from device */
 		read_lock(&hci_sk_list.lock);
 		sk_for_each(sk, node, &hci_sk_list.head) {
-			local_bh_disable();
 			bh_lock_sock_nested(sk);
 			if (hci_pi(sk)->hdev == hdev) {
 				hci_pi(sk)->hdev = NULL;
@@ -778,7 +777,6 @@ static int hci_sock_dev_event(struct notifier_block *this, unsigned long event,
 				hci_dev_put(hdev);
 			}
 			bh_unlock_sock(sk);
-			local_bh_enable();
 		}
 		read_unlock(&hci_sk_list.lock);
 	}
-- 
1.7.7.5


  reply	other threads:[~2011-12-27 17:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-27 17:28 [PATCH 1/5] Bluetooth: Fix context in rfcomm_sock_lock Gustavo F. Padovan
2011-12-27 17:28 ` [PATCH 2/5] Bluetooth: Fix context in RFCOMM tty Gustavo F. Padovan
2011-12-27 17:28   ` [PATCH 3/5] Bluetooth: Remove *_bh locks from SCO Gustavo F. Padovan
2011-12-27 17:28     ` Gustavo F. Padovan [this message]
2011-12-27 17:28       ` [PATCH 5/5] Bluetooth: Remove *_bh from socket list lock Gustavo F. Padovan
2012-01-02 22:21         ` Marcel Holtmann
2012-01-02 22:20     ` [PATCH 3/5] Bluetooth: Remove *_bh locks from SCO Marcel Holtmann
2012-01-02 22:19   ` [PATCH 2/5] Bluetooth: Fix context in RFCOMM tty Marcel Holtmann
2012-01-02 22:18 ` [PATCH 1/5] Bluetooth: Fix context in rfcomm_sock_lock Marcel Holtmann
2012-01-03  0:18   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1325006928-3338-4-git-send-email-padovan@profusion.mobi \
    --to=padovan@profusion.mobi \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox