[PATCH] Fix wiimote device_get_address to use new API

[PATCH] Fix wiimote device_get_address to use new API

[David Herrmann]

Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
patch converts the plugin to use the new API.
---
 plugins/wiimote.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/plugins/wiimote.c b/plugins/wiimote.c
index fead72a..1ae638b 100644
--- a/plugins/wiimote.c
+++ b/plugins/wiimote.c
@@ -63,7 +63,7 @@ static ssize_t wii_pincb(struct btd_adapter *adapter, struct btd_device *device,
 	char addr[18];
 
 	adapter_get_address(adapter, &sba);
-	device_get_address(device, &dba);
+	device_get_address(device, &dba, NULL);
 	ba2str(&dba, addr);
 
 	vendor = btd_device_get_vendor(device);
-- 
1.7.8.1

Re: [PATCH] Fix wiimote device_get_address to use new API

[Anderson Lizardo]

Hi David,

On Thu, Dec 29, 2011 at 12:59 PM, David Herrmann
<dh.herrmann@googlemail.com> wrote:
> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
> device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
> patch converts the plugin to use the new API.

You should consider adding this plugin to bootstrap-configure, so it
is not forgotten again. Currently it is not built by running
"./bootstrap-configure"

Regards,
-- 
Anderson Lizardo
Instituto Nokia de Tecnologia - INdT
Manaus - Brazil

[PATCH] Add wiimote plugin to bootstrap-configure

[David Herrmann]

Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
---
 bootstrap-configure |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bootstrap-configure b/bootstrap-configure
index 94da969..89ea156 100755
--- a/bootstrap-configure
+++ b/bootstrap-configure
@@ -34,5 +34,6 @@ fi
 		--enable-cups \
 		--enable-sap \
 		--enable-thermometer \
+		--enable-wiimote \
 		--disable-pcmcia \
 		--disable-datafiles $*
-- 
1.7.8.1

Re: [PATCH] Fix wiimote device_get_address to use new API

[David Herrmann]

On Thu, Dec 29, 2011 at 6:15 PM, Anderson Lizardo
<anderson.lizardo@openbossa.org> wrote:
> Hi David,
>
> On Thu, Dec 29, 2011 at 12:59 PM, David Herrmann
> <dh.herrmann@googlemail.com> wrote:
>> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API for
>> device_get_name but apparently missed fixing the call in plugins/wiimote.c. This
>> patch converts the plugin to use the new API.
>
> You should consider adding this plugin to bootstrap-configure, so it
> is not forgotten again. Currently it is not built by running
> "./bootstrap-configure"

Ah, I didn't know of it. I've sent a separate patch. Thanks.

[PATCH v2] Add wiimote plugin to bootstrap-configure

[David Herrmann]

---
Sorry, this time without the signed-off-by line.

 bootstrap-configure |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/bootstrap-configure b/bootstrap-configure
index 94da969..89ea156 100755
--- a/bootstrap-configure
+++ b/bootstrap-configure
@@ -34,5 +34,6 @@ fi
 		--enable-cups \
 		--enable-sap \
 		--enable-thermometer \
+		--enable-wiimote \
 		--disable-pcmcia \
 		--disable-datafiles $*
-- 
1.7.8.1

Re: [PATCH] Fix wiimote device_get_address to use new API

[Johan Hedberg]

Hi David,

On Thu, Dec 29, 2011, David Herrmann wrote:
> Commit b06899eace1f484b387aae0e568fb1da988b468c introduced a new API
> for device_get_name but apparently missed fixing the call in
> plugins/wiimote.c. This patch converts the plugin to use the new API.
> ---
>  plugins/wiimote.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Applied after the obvious s/get_name/get_address/ in the commit message.
Thanks.

Johan

Re: [PATCH v2] Add wiimote plugin to bootstrap-configure

[Johan Hedberg]

Hi David,

On Thu, Dec 29, 2011, David Herrmann wrote:
> ---
> Sorry, this time without the signed-off-by line.
> 
>  bootstrap-configure |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied. Thanks.

Johan