Re: [RFC v0 2/3] Bluetooth: Use hci_conn_auth() instead of open coded version

[Marcel Holtmann <marcel@holtmann.org>]

Hi Daniel,

> Note this will also enable the encryption which will
> not happen in the open coded version.
> 
> Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
> ---
>  net/bluetooth/hci_event.c |   12 ++----------
>  1 files changed, 2 insertions(+), 10 deletions(-)
> 
> diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
> index d37f5b2..453e483 100644
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -1296,11 +1296,7 @@ static void hci_cs_remote_name_req(struct hci_dev *hdev, __u8 status)
>  	if (!hci_outgoing_auth_needed(hdev, conn))
>  		goto unlock;
>  
> -	if (!test_and_set_bit(HCI_CONN_AUTH_PEND, &conn->pend)) {
> -		struct hci_cp_auth_requested cp;
> -		cp.handle = __cpu_to_le16(conn->handle);
> -		hci_send_cmd(hdev, HCI_OP_AUTH_REQUESTED, sizeof(cp), &cp);
> -	}
> +	hci_conn_auth(conn, BT_SECURITY_HIGH, conn->auth_type);

this is not a replacement. Not even a little bit. You are currently
messing with powers that can break qualification.

Regards

Marcel