From: Marcel Holtmann <marcel@holtmann.org>
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: linux-bluetooth@vger.kernel.org, padovan@profusion.mobi
Subject: Re: [PATCH] Bluetooth: dtl1: Fix memleak in probe()
Date: Sat, 07 Jan 2012 13:04:50 -0800 [thread overview]
Message-ID: <1325970290.6454.127.camel@aeonflux> (raw)
In-Reply-To: <1325945981-11330-5-git-send-email-dh.herrmann@googlemail.com>
Hi David,
> We currently leak the driver info structure if dtl1_config fails. If we add a
> kfree() to dtl1_release to fix this, then dtl1_release and dtl1_detach are
> identical so this merges both functions.
>
> Signed-off-by: David Herrmann <dh.herrmann@googlemail.com>
> ---
> drivers/bluetooth/dtl1_cs.c | 20 +++-----------------
> 1 files changed, 3 insertions(+), 17 deletions(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-01-07 21:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-07 14:19 [PATCH] Bluetooth: hci-uart-ll: Use GFP_ATOMIC in open() David Herrmann
2012-01-07 14:19 ` [PATCH] Bluetooth: hci-uart-h4: " David Herrmann
2012-01-07 21:03 ` Marcel Holtmann
2012-01-08 20:36 ` Johan Hedberg
2012-01-07 14:19 ` [PATCH] Bluetooth: hci-uart-bcsp: " David Herrmann
2012-01-07 21:03 ` Marcel Holtmann
2012-01-08 20:36 ` Johan Hedberg
2012-01-07 14:19 ` [PATCH] Bluetooth: hci-uart-ath: " David Herrmann
2012-01-07 21:04 ` Marcel Holtmann
2012-01-08 20:36 ` Johan Hedberg
2012-01-07 14:19 ` [PATCH] Bluetooth: dtl1: Fix memleak in probe() David Herrmann
2012-01-07 21:04 ` Marcel Holtmann [this message]
2012-01-08 20:37 ` Johan Hedberg
2012-01-07 21:03 ` [PATCH] Bluetooth: hci-uart-ll: Use GFP_ATOMIC in open() Marcel Holtmann
2012-01-08 20:34 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1325970290.6454.127.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=dh.herrmann@googlemail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=padovan@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox